From: Andy Wingo <wingo@pobox.com>
To: Daniel Hartwig <mandyke@gmail.com>
Cc: 10109@debbugs.gnu.org
Subject: bug#10109: [PATCH] (web http): list-style headers do not validate
Date: Thu, 22 Dec 2011 08:21:06 -0500 [thread overview]
Message-ID: <8762h8rbct.fsf@pobox.com> (raw)
In-Reply-To: <CAN3veRc1mWKjOs7yDoFc0_cjOMwe-3qgqOWoDQ-WS001LSCGeQ@mail.gmail.com> (Daniel Hartwig's message of "Sun, 27 Nov 2011 23:11:08 +0800")
On Sun 27 Nov 2011 10:11, Daniel Hartwig <mandyke@gmail.com> writes:
> My apologies for not noticing earlier, but I have spotted a couple
> minor issues with both the previous patch and original code that are
> corrected by the attached. All relate to the "Cache-Control" header:
>
> - `max-stale' has optional value (previous code requires it)
> - some directives do not have values (`no-store', etc.)
> - there are `cache-extension' directives that may or may not have a value
>
> Attached patch tidies this up
Thanks, it was a great patch. Applied and pushed.
> with explicit validation of all defined
> directives, though it leaves open one issue with the cache-extension
> directives:
I fixed this one, I think.
Happy hacking,
Andy
--
http://wingolog.org/
prev parent reply other threads:[~2011-12-22 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 18:18 bug#10109: [PATCH] (web http): list-style headers do not validate Daniel Hartwig
2011-11-23 20:25 ` Andy Wingo
2011-11-27 15:11 ` Daniel Hartwig
2011-12-22 13:21 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762h8rbct.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=10109@debbugs.gnu.org \
--cc=mandyke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).