From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Marius Bakke Newsgroups: gmane.lisp.guile.bugs Subject: bug#48368: bug#47172: Shepherd 0.8.1 tests fail on core-updates Date: Sun, 23 May 2021 17:23:48 +0200 Message-ID: <875yz9qxrv.fsf__13968.8555778534$1621783468$gmane$org@gnu.org> References: <37305bfa08faea95b45a6496623154c2ebab1f11.camel@zaclys.net> <87zgwl4ui0.fsf@gnu.org> <87v9794l2a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48368@debbugs.gnu.org To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 47172@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sun May 23 17:24:23 2021 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkpxn-0004KF-2M for guile-bugs@m.gmane-mx.org; Sun, 23 May 2021 17:24:23 +0200 Original-Received: from localhost ([::1]:54018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkpxm-0004V1-6C for guile-bugs@m.gmane-mx.org; Sun, 23 May 2021 11:24:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkpxT-0004TH-2M for bug-guile@gnu.org; Sun, 23 May 2021 11:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58341) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkpxS-0001hu-Bi for bug-guile@gnu.org; Sun, 23 May 2021 11:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkpxS-0003cu-8c for bug-guile@gnu.org; Sun, 23 May 2021 11:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 23 May 2021 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48368 X-GNU-PR-Package: guile Original-Received: via spool by 48368-submit@debbugs.gnu.org id=B48368.162178343913923 (code B ref 48368); Sun, 23 May 2021 15:24:02 +0000 Original-Received: (at 48368) by debbugs.gnu.org; 23 May 2021 15:23:59 +0000 Original-Received: from localhost ([127.0.0.1]:41653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkpxP-0003cP-6N for submit@debbugs.gnu.org; Sun, 23 May 2021 11:23:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkpxM-0003c7-SK; Sun, 23 May 2021 11:23:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34382) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkpxH-0001fq-Mq; Sun, 23 May 2021 11:23:51 -0400 Original-Received: from host-37-191-231-185.lynet.no ([37.191.231.185]:44036 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkpxG-0006Gs-82; Sun, 23 May 2021 11:23:51 -0400 In-Reply-To: <87v9794l2a.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:10106 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s skriver: > Ludovic Court=C3=A8s skribis: > >> This turns out to be due to a=E2=80=A6 miscompilation bug. >> >> In (shepherd scripts herd), =E2=80=98run-command=E2=80=99 has this code: >> >> (let ((sock (open-connection socket-file)) >> (action* (if (and (eq? action 'detailed-status) >> (memq service '(root shepherd))) >> 'status >> action))) >> =E2=80=A6) >> >> Problem is that everything works as if (eq? action 'detailed-status) >> was omitted, such that =E2=80=98herd stop root=E2=80=99 is interpreted a= s =E2=80=98herd status >> root=E2=80=99. > > A workaround that works with 3.0.7 is swapping the two =E2=80=98and=E2=80= =99 > sub-expressions: > > diff --git a/modules/shepherd/scripts/herd.scm b/modules/shepherd/scripts= /herd.scm > index 106de1e..39d2e34 100644 > --- a/modules/shepherd/scripts/herd.scm > +++ b/modules/shepherd/scripts/herd.scm > @@ -126,8 +126,8 @@ of pairs." > the daemon via SOCKET-FILE." > (with-system-error-handling > (let ((sock (open-connection socket-file)) > - (action* (if (and (eq? action 'detailed-status) > - (memq service '(root shepherd))) > + (action* (if (and (memq service '(root shepherd)) > + (eq? action 'detailed-status)) > 'status > action))) > ;; Send the command. Cc'ing the relevant Guile bug: https://bugs.gnu.org/48368 See also commit 79be6a985799adc6d663890250f4fb7c12f015b4 on 'core-updates' that builds with -O1 as a less satisfactory workaround. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYKpzhA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHd0CgD9FsWiNMu2PxB/773BI2hOmYPKZqyX+KbAy05R C7+xubIBAPcyjBy9TtmqfG0aCSUu1r6a8dmFKkJm4r4eb5fLEwEK =o7Sr -----END PGP SIGNATURE----- --=-=-=--