From: "Ludovic Courtès" <ludo@gnu.org>
To: Andreas Rottmann <mail@r0tty.org>
Cc: 39610@debbugs.gnu.org
Subject: bug#39610: R6RS `flush-output-port` not playing along with `transcoded-port`
Date: Sat, 21 Mar 2020 18:55:46 +0100 [thread overview]
Message-ID: <874kuhzj6l.fsf@gnu.org> (raw)
In-Reply-To: <87wo8orvr9.fsf@londo.h.r0tty.org> (Andreas Rottmann's message of "Sat, 15 Feb 2020 11:27:06 +0100")
Hi Andreas,
And welcome back! :-)
Andreas Rottmann <mail@r0tty.org> skribis:
> Andreas Rottmann <mail@r0tty.org> writes:
>
>> [...] I isolated the cause; the following snippet hangs on Guile 2.2
>> and 3.0, while it worked as expected on 2.0:
>>
>> ;; ------------------
>> (import (rnrs))
>>
>> (let* ((p (pipe))
>> (in (car p))
>> (out (transcoded-port (cdr p) (make-transcoder (utf-8-codec)))))
>> (put-datum out "foo")
>> (flush-output-port out)
>> (display "Should have written to pipe by now, attempting reading a byte\n")
>> (display "Got")
>> (display (get-u8 in))
>> (newline))
>> ;; -------------------
>>
>> It seems the underlying port is no longer flushed to the OS, so the
>> `get-u8` now hangs waiting for input, starting with Guile 2.2.
>>
> I'd like to add that this is indeed not passing data to the OS, as
> verified by strace. Also, I have now figured out the commit introducing
> the regression, namely 8399e7af5 ("Generic port facility provides
> buffering uniformly"); the commit before (e8eeeeb1d) still runs the
> above code to completion.
Actually I think the code above behaves as expected. ‘pipe’ returns
buffered ports by default. When flushing the transcoded port,
‘transcoded_port_write’ is called, but then bytes written to the pipe
are buffered.
The fix is to add:
(setvbuf (cdr p) 'none)
Does that make sense?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-03-21 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 0:08 bug#39610: R6RS `flush-output-port` not playing along with `transcoded-port` Andreas Rottmann
2020-02-15 10:27 ` Andreas Rottmann
2020-03-21 17:55 ` Ludovic Courtès [this message]
2020-03-22 22:50 ` Andreas Rottmann
2020-03-23 9:22 ` Ludovic Courtès
2020-03-29 21:15 ` Andreas Rottmann
2020-02-15 13:37 ` Andreas Rottmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kuhzj6l.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39610@debbugs.gnu.org \
--cc=mail@r0tty.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).