From: Andy Wingo <wingo@pobox.com>
To: ludovic.courtes@inria.fr (Ludovic Courtès)
Cc: 14640-done@debbugs.gnu.org, ludo@gnu.org
Subject: bug#14640: SA_RESTART prevents execution of signal handlers
Date: Tue, 21 Jun 2016 09:59:33 +0200 [thread overview]
Message-ID: <8737o73rbu.fsf@pobox.com> (raw)
In-Reply-To: <87wpljdlta.fsf@inria.fr> ("Ludovic Courtès"'s message of "Tue, 21 Jun 2016 09:48:33 +0200")
On Tue 21 Jun 2016 09:48, ludovic.courtes@inria.fr (Ludovic Courtès) writes:
> Andy Wingo <wingo@pobox.com> skribis:
>
>> On Mon 17 Jun 2013 15:54, ludovic.courtes@inria.fr (Ludovic Courtès) writes:
>>
>>> When using SA_RESTART, signal handlers are never executed, as in this
>>> example (checked on 2.0.9+):
>>>
>>> (sigaction SIGALRM
>>> (lambda (signum)
>>> (pk 'sig signum))
>>> SA_RESTART)
>>> (alarm 3)
>>> (pk 'char (read-char))
>>>
>>> Presumably this is because the read(2) syscall is automatically
>>> restarted, leaving no chance for the handler async to run.
>>
>> Thinking about this a bit -- since we always handle signals
>> asynchronously and have no intention of handling them synchronously,
>> then we just have to document this behavior. Done in e877e1b:
>
> I think it’s problematic though. With the current design, signal
> delivery is unreliable (with or without SA_RESTART; what we observe with
> SA_RESTART occurs similarly if you make a syscall right after queuing,
> but not running, an async.)
Can you expect any kind of reasonable behavior with SA_RESTART? I think
not.
> The more I think about it, the more I think a different approach is
> needed. On GNU/Linux, signalfd(2) may be part of the solution.
We already do the equivalent of signalfd(), with our self-pipe trick.
And an fd doesn't help you if the syscall has no associated fd. Signals
are just a problem. I agree we can do better though :)
If you are just concerned about read and write, I think the right thing
is non-blocking fd's, and making the C read/write waiters also add the
signal FD to their poll set. WDYT?
Andy
next prev parent reply other threads:[~2016-06-21 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:54 bug#14640: SA_RESTART prevents execution of signal handlers Ludovic Courtès
2016-06-21 6:37 ` Andy Wingo
2016-06-21 7:48 ` Ludovic Courtès
2016-06-21 7:59 ` Andy Wingo [this message]
2016-06-21 9:46 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737o73rbu.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=14640-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).