From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#39211: [PATCH 1/1] 00-repl-server.test: don't use fixed path for socket Date: Tue, 21 Jan 2020 17:50:54 +0100 Message-ID: <8736c8da8h.fsf@gnu.org> References: <20200121032214.1908896-1-rlb@defaultvalue.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="112934"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 39211@debbugs.gnu.org To: Rob Browning Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Tue Jan 21 17:52:11 2020 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itwl9-000TBo-AS for guile-bugs@m.gmane-mx.org; Tue, 21 Jan 2020 17:52:11 +0100 Original-Received: from localhost ([::1]:58168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwl8-0003qq-AC for guile-bugs@m.gmane-mx.org; Tue, 21 Jan 2020 11:52:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40931) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwl1-0003oY-Gr for bug-guile@gnu.org; Tue, 21 Jan 2020 11:52:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itwl0-0008Td-LG for bug-guile@gnu.org; Tue, 21 Jan 2020 11:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itwl0-0008TQ-Gr for bug-guile@gnu.org; Tue, 21 Jan 2020 11:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itwl0-0006hr-Gj for bug-guile@gnu.org; Tue, 21 Jan 2020 11:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 21 Jan 2020 16:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39211 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 39211-submit@debbugs.gnu.org id=B39211.157962547225692 (code B ref 39211); Tue, 21 Jan 2020 16:52:02 +0000 Original-Received: (at 39211) by debbugs.gnu.org; 21 Jan 2020 16:51:12 +0000 Original-Received: from localhost ([127.0.0.1]:48342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwk8-0006gF-LK for submit@debbugs.gnu.org; Tue, 21 Jan 2020 11:51:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwk2-0006fg-JP for 39211@debbugs.gnu.org; Tue, 21 Jan 2020 11:51:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1itwjx-000824-6N; Tue, 21 Jan 2020 11:50:57 -0500 Original-Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=35186 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1itwjw-0006iS-GU; Tue, 21 Jan 2020 11:50:57 -0500 In-Reply-To: <20200121032214.1908896-1-rlb@defaultvalue.org> (Rob Browning's message of "Mon, 20 Jan 2020 21:22:14 -0600") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:9533 Archived-At: Hi Rob, Rob Browning skribis: > Even setting aside any security concerns, this caused tests to fail if > you ran them as a given user and then ran them again as another user. Oops, indeed. > It didn't look like we have anything like mkdtemp or I'd have used it > instead. And it looks like this might apply to, and it would be nice > to have something like it on stable-2.2 as well. I thought we had =E2=80=98mkdtemp!=E2=80=99 but it=E2=80=99s just in Guix. = :-/ Well we can go that way for now, perhaps with a FIXME comment suggesting the use of =E2=80=98mkdtemp!=E2=80=99 once it=E2=80=99s available. Also please make sure to include a ChangeLog-style commit log. Apart from that it LGTM! I think we should add =E2=80=98mkdtemp!=E2=80=99 to libguile in a separate = commit; it=E2=80=99s OK to _add_ procedures during a stable release. Thanks, Ludo=E2=80=99.