unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#39974: Guile fails to build without makeinfo
@ 2020-03-07  9:53 Fabrice Fontaine
  2020-03-07 16:04 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2020-03-07  9:53 UTC (permalink / raw)
  To: 39974

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

guile fails to build without makeinfo:

make[4]: Entering directory
'/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/doc/ref'
  MAKEINFO guile.info
/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/build-aux/missing:
line 81: makeinfo: command not found
WARNING: 'makeinfo' is missing on your system.
         You should only need it if you modified a '.texi' file, or
         any other file indirectly affecting the aspect of the manual.
         You might want to install the Texinfo package:
         <http://www.gnu.org/software/texinfo/>
         The spurious makeinfo call might also be the consequence of
         using a buggy 'make' (AIX, DU, IRIX), in which case you might
         want to install GNU make:
         <http://www.gnu.org/software/make/>

To fix this build failure, the attached patch don't build the doc
subdir if makeinfo is not available.

Fixes:
 - http://autobuild.buildroot.org/results/9605aac6f760bfff190d0ab95fa50f65486ffe90

[-- Attachment #2: 0001-Makefile.am-fix-build-without-makeinfo.patch --]
[-- Type: text/x-patch, Size: 1606 bytes --]

From 9304ad88a5f4b083d348563c5de00da53b34cf46 Mon Sep 17 00:00:00 2001
From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Date: Fri, 6 Mar 2020 23:20:39 +0100
Subject: [PATCH] Makefile.am: fix build without makeinfo

Don't build doc subdir if makeinfo is not available otherwise build
fails on:

make[4]: Entering directory '/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/doc/ref'
  MAKEINFO guile.info
/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/build-aux/missing: line 81: makeinfo: command not found
WARNING: 'makeinfo' is missing on your system.
         You should only need it if you modified a '.texi' file, or
         any other file indirectly affecting the aspect of the manual.
         You might want to install the Texinfo package:
         <http://www.gnu.org/software/texinfo/>
         The spurious makeinfo call might also be the consequence of
         using a buggy 'make' (AIX, DU, IRIX), in which case you might
         want to install GNU make:
         <http://www.gnu.org/software/make/>

Fixes:
 - http://autobuild.buildroot.org/results/9605aac6f760bfff190d0ab95fa50f65486ffe90

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 Makefile.am | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index ebbf6d476..2270afb9f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -38,8 +38,12 @@ SUBDIRS =					\
 	test-suite				\
 	benchmark-suite				\
 	gc-benchmarks				\
-	am					\
+	am
+
+if HAVE_MAKEINFO
+SUBDIRS +=					\
 	doc
+endif
 
 DIST_SUBDIRS = $(SUBDIRS) prebuilt
 
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* bug#39974: Guile fails to build without makeinfo
  2020-03-07  9:53 bug#39974: Guile fails to build without makeinfo Fabrice Fontaine
@ 2020-03-07 16:04 ` Ludovic Courtès
  2020-03-07 16:35   ` Fabrice Fontaine
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-03-07 16:04 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: 39974

Hello,

Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:

> guile fails to build without makeinfo:
>
> make[4]: Entering directory
> '/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/doc/ref'
>   MAKEINFO guile.info
> /nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/build-aux/missing:
> line 81: makeinfo: command not found

AFAIK, ‘makeinfo’ is needed if and only if one modifies the .texi files,
or perhaps the ‘configure’ file.

Could it be what happened here?

BTW, 2.0 is an old series that is no longer maintained (the current
stable series is 3.0, and the previous one is 2.2).

Thanks,
Ludo’.





^ permalink raw reply	[flat|nested] 6+ messages in thread
* bug#39974: Guile fails to build without makeinfo
  2020-03-07 16:04 ` Ludovic Courtès
@ 2020-03-07 16:35   ` Fabrice Fontaine
  2020-03-07 20:40     ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2020-03-07 16:35 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 39974

Hello,

Le sam. 7 mars 2020 à 17:04, Ludovic Courtès <ludo@gnu.org> a écrit :
>
> Hello,
>
> Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:
>
> > guile fails to build without makeinfo:
> >
> > make[4]: Entering directory
> > '/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/doc/ref'
> >   MAKEINFO guile.info
> > /nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/build-aux/missing:
> > line 81: makeinfo: command not found
>
> AFAIK, ‘makeinfo’ is needed if and only if one modifies the .texi files,
> or perhaps the ‘configure’ file.
>
> Could it be what happened here?
Yes, this build failure is raised by one of our buidlroot autobuilders.
We're running autoreconf as we have a patch that updates configure.ac:
https://git.buildroot.net/buildroot/tree/package/guile/0002-calculate-csqrt_manually.patch.
If your interested in applying this patch upstream, I can send it to
the mailing list.
>
> BTW, 2.0 is an old series that is no longer maintained (the current
> stable series is 3.0, and the previous one is 2.2).
Our current version of guile is indeed pretty old, one of our users
sent a patch to bump it to 3.0:
https://patchwork.ozlabs.org/patch/1246994.
However, I assume that this build failure won't be fixed in 3.0 as
we'll still have to update configure.ac.

So, in the end, I saw that HAVE_MAKEINFO was added quite a while ago (in 2001):
http://git.savannah.gnu.org/cgit/guile.git/commit/?id=a9d78896d1737c429ca8640d5e2fe0814a2ea20c
However, this variable was never used so it seemed right to me to use
it to fix this build failure
>
> Thanks,
> Ludo’.
Best Regards,

Fabrice





^ permalink raw reply	[flat|nested] 6+ messages in thread
* bug#39974: Guile fails to build without makeinfo
  2020-03-07 16:35   ` Fabrice Fontaine
@ 2020-03-07 20:40     ` Ludovic Courtès
  2020-03-07 22:07       ` Fabrice Fontaine
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-03-07 20:40 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: 39974

Hi,

Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:

>> Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:
>>
>> > guile fails to build without makeinfo:
>> >
>> > make[4]: Entering directory
>> > '/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/doc/ref'
>> >   MAKEINFO guile.info
>> > /nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/build-aux/missing:
>> > line 81: makeinfo: command not found
>>
>> AFAIK, ‘makeinfo’ is needed if and only if one modifies the .texi files,
>> or perhaps the ‘configure’ file.
>>
>> Could it be what happened here?
> Yes, this build failure is raised by one of our buidlroot autobuilders.
> We're running autoreconf as we have a patch that updates configure.ac:

OK.  From Guile’s perspective, it’s not a bug that ‘makeinfo’ is needed
in this case.

> https://git.buildroot.net/buildroot/tree/package/guile/0002-calculate-csqrt_manually.patch.
> If your interested in applying this patch upstream, I can send it to
> the mailing list.

I don’t think we would apply the patch because it’s uClibc-specific,
AIUI.

However, instead of patching ‘configure.ac’, you can run:

  ./configure guile_cv_use_csqrt=no

to achieve the same effect as the patch.

Let me know if it works for you!

Thanks,
Ludo’.





^ permalink raw reply	[flat|nested] 6+ messages in thread
* bug#39974: Guile fails to build without makeinfo
  2020-03-07 20:40     ` Ludovic Courtès
@ 2020-03-07 22:07       ` Fabrice Fontaine
  2020-03-08 11:09         ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2020-03-07 22:07 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 39974

Hi,

Le sam. 7 mars 2020 à 21:40, Ludovic Courtès <ludo@gnu.org> a écrit :
>
> Hi,
>
> Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:
>
> >> Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:
> >>
> >> > guile fails to build without makeinfo:
> >> >
> >> > make[4]: Entering directory
> >> > '/nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/doc/ref'
> >> >   MAKEINFO guile.info
> >> > /nvmedata/autobuild/instance-7/output-1/build/host-guile-2.0.14/build-aux/missing:
> >> > line 81: makeinfo: command not found
> >>
> >> AFAIK, ‘makeinfo’ is needed if and only if one modifies the .texi files,
> >> or perhaps the ‘configure’ file.
> >>
> >> Could it be what happened here?
> > Yes, this build failure is raised by one of our buidlroot autobuilders.
> > We're running autoreconf as we have a patch that updates configure.ac:
>
> OK.  From Guile’s perspective, it’s not a bug that ‘makeinfo’ is needed
> in this case.
OK, then instead of this patch, do you think that adding a
--disable-doc option could be acceptable?
>
> > https://git.buildroot.net/buildroot/tree/package/guile/0002-calculate-csqrt_manually.patch.
> > If your interested in applying this patch upstream, I can send it to
> > the mailing list.
>
> I don’t think we would apply the patch because it’s uClibc-specific,
> AIUI.
>
> However, instead of patching ‘configure.ac’, you can run:
>
>   ./configure guile_cv_use_csqrt=no
>
> to achieve the same effect as the patch.
>
> Let me know if it works for you!
OK, I'll update buildroot with your proposal as we try to avoid
carrying out non-upstreamable patch.
>
> Thanks,
> Ludo’.
Best Regards,

Fabrice





^ permalink raw reply	[flat|nested] 6+ messages in thread
* bug#39974: Guile fails to build without makeinfo
  2020-03-07 22:07       ` Fabrice Fontaine
@ 2020-03-08 11:09         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2020-03-08 11:09 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: 39974

Hello,

Fabrice Fontaine <fontaine.fabrice@gmail.com> skribis:

> Le sam. 7 mars 2020 à 21:40, Ludovic Courtès <ludo@gnu.org> a écrit :

[...]

>> > Yes, this build failure is raised by one of our buidlroot autobuilders.
>> > We're running autoreconf as we have a patch that updates configure.ac:
>>
>> OK.  From Guile’s perspective, it’s not a bug that ‘makeinfo’ is needed
>> in this case.
> OK, then instead of this patch, do you think that adding a
> --disable-doc option could be acceptable?

No because again, when building from a tarball, ‘makeinfo’ is not needed
(the Info files are included in the tarball).  I hope that makes sense!

Thanks,
Ludo’.





^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-08 11:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-07  9:53 bug#39974: Guile fails to build without makeinfo Fabrice Fontaine
2020-03-07 16:04 ` Ludovic Courtès
2020-03-07 16:35   ` Fabrice Fontaine
2020-03-07 20:40     ` Ludovic Courtès
2020-03-07 22:07       ` Fabrice Fontaine
2020-03-08 11:09         ` Ludovic Courtès

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).