unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Andy Wingo <wingo@igalia.com>, 40737@debbugs.gnu.org
Subject: bug#40737: Segfault in arm gcc7, thumb2 builroot, with arm patch
Date: Sat, 20 Jun 2020 16:37:59 +0200	[thread overview]
Message-ID: <87366pby60.fsf@gnu.org> (raw)
In-Reply-To: <877dw1bzpv.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 20 Jun 2020 16:04:28 +0200")

Hi,

Ludovic Courtès <ludo@gnu.org> skribis:

> Andrew Gierth <andrew@tao11.riddles.org.uk> skribis:
>
>> diff --git a/libguile/lightening/lightening/arm-cpu.c b/libguile/lightening/lightening/arm-cpu.c
>> index 4445266af..2b4eecc29 100644
>> --- a/libguile/lightening/lightening/arm-cpu.c
>> +++ b/libguile/lightening/lightening/arm-cpu.c
>> @@ -230,7 +230,7 @@ encode_thumb_immediate(unsigned int v)
>>      return ((v & 0xff) | (1 << 12));
>>    /* abcdefgh 00000000 abcdefgh 00000000 */
>>    if (((v & 0xffff0000) >> 16) == (v & 0xffff) && (v & 0xff) == 0)
>> -    return ((v & 0x000000ff) | (2 << 12));
>> +    return (((v & 0x0000ff00) >> 8) | (2 << 12));
>>    /* abcdefgh abcdefgh abcdefgh abcdefgh */
>>    if ( (v &    0xff)        == ((v &     0xff00) >>  8) &&
>>         ((v &   0xff00) >> 8) == ((v &   0xff0000) >> 16) &&
>
> I pushed this fix to the lightening repo on your behalf:
>
>   https://gitlab.com/wingo/lightening/-/commit/1bb909a44d2303f88bb05125fc6742e97f80cd1d
>
> The CI jobs pass:
>
>   https://gitlab.com/wingo/lightening/-/pipelines/158337465
>
> I’ll try merging it into Guile, but do you have a test that reproduces
> the original bug, either at the Guile level or in C using the lightening
> API?  Perhaps the test that Dale posted yesterday at
> <https://paste.debian.net/1152897/>?

Replying to myself after our discussion on IRC: I’ve merged the test you
provided, Dale (with the addition of enter/leave_jit_abi), and pushed.

  https://gitlab.com/wingo/lightening/-/commit/24ef197b1269f8371b1f4a412caa6d2b99d66839

I’ll look into merging into Guile later today, and then I guess we can
close this bug.

Thank you!

Ludo’.





  reply	other threads:[~2020-06-20 14:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 19:34 bug#40737: Segfault in arm gcc7, thumb2 builroot, with arm patch dsmich
2020-04-20 19:41 ` bug#40737: Forgot command output dsmich
2020-04-20 19:48 ` bug#40737: Even more info dsmich
2020-04-21 12:36 ` dsmich
2020-06-17 22:36 ` bug#40737: Segfault in arm gcc7, thumb2 builroot, with arm patch Ludovic Courtès
2020-06-18 13:49 ` dsmich
2020-06-18 14:54   ` Ludovic Courtès
2020-06-18 15:17 ` dsmich
2020-06-19 16:07 ` Andrew Gierth
2020-06-20 14:04   ` Ludovic Courtès
2020-06-20 14:37     ` Ludovic Courtès [this message]
2020-06-19 19:10 ` dsmich
2020-06-22 14:34 ` dsmich
2020-06-22 15:18 ` bug#40737: 40737-done@debbugs.gnu.org Dale Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87366pby60.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40737@debbugs.gnu.org \
    --cc=andrew@tao11.riddles.org.uk \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).