From: Andy Wingo <wingo@pobox.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 48089-done@debbugs.gnu.org
Subject: bug#48089: Guile 3.0.6 returns zero-indexed locations for ‘read-error’
Date: Thu, 29 Apr 2021 22:04:52 +0200 [thread overview]
Message-ID: <8735v8luvv.fsf@pobox.com> (raw)
In-Reply-To: <87o8dxmo48.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 29 Apr 2021 11:33:27 +0200")
Done :)
On Thu 29 Apr 2021 11:33, Ludovic Courtès <ludo@gnu.org> writes:
> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> Guile 3.0.6 returns zero-indexed (instead of one-indexed) source code
>> locations for ‘read-error’. Here’s a 3.0.6/3.0.5 comparison:
>>
>> $ /gnu/store/r2nr74rwhpqg16y1lyi6l0jn3lwx4yyz-guile-3.0.6/bin/guile <(echo '(')
>> ice-9/read.scm:126:4: In procedure lp:
>> /dev/fd/63:1:0: unexpected end of input while searching for: )
>> $ guile <(echo '(')
>> ERROR: In procedure primitive-load:
>> In procedure scm_i_lreadparen: /dev/fd/63:2:1: end of file
>
> Here’s a test case waiting to succeed! :-)
>
> diff --git a/test-suite/tests/reader.test b/test-suite/tests/reader.test
> index fad531b39..231e69553 100644
> --- a/test-suite/tests/reader.test
> +++ b/test-suite/tests/reader.test
> @@ -212,6 +212,18 @@
>
> \f
> (with-test-prefix "mismatching parentheses"
> + (pass-if-equal "read-error location"
> + '("foo.scm:3:1: unexpected end of input while searching for: ~A" #\))
> + (catch 'read-error
> + (lambda ()
> + ;; The missing closing paren error should be located on line 3,
> + ;; column 1 (one-indexed).
> + (call-with-input-string "\n (hi there!\n"
> + (lambda (port)
> + (set-port-filename! port "foo.scm")
> + (read port))))
> + (lambda (key proc message args . _)
> + (cons message args))))
> (pass-if-exception "opening parenthesis"
> exception:eof
> (read-string "("))
>
>
> Ludo’.
prev parent reply other threads:[~2021-04-29 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 22:33 bug#48089: Guile 3.0.6 returns zero-indexed locations for ‘read-error’ Ludovic Courtès
2021-04-29 9:33 ` Ludovic Courtès
2021-04-29 20:04 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735v8luvv.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=48089-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).