From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#24659: 'mkdir' procedure is neither thread-safe nor safe (2.0.12) Date: Tue, 11 Oct 2016 11:13:19 +0200 Message-ID: <871szn1c5s.fsf@gnu.org> References: <87pon8ma3w.fsf@gnu.org> <20161010182537.GA27089@tuxteam.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1476177290 27750 195.159.176.226 (11 Oct 2016 09:14:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2016 09:14:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24659@debbugs.gnu.org To: Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Oct 11 11:14:45 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btt8d-00038B-5H for guile-bugs@m.gmane.org; Tue, 11 Oct 2016 11:14:19 +0200 Original-Received: from localhost ([::1]:54504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btt8b-0005gN-Tu for guile-bugs@m.gmane.org; Tue, 11 Oct 2016 05:14:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btt8R-0005gC-PB for bug-guile@gnu.org; Tue, 11 Oct 2016 05:14:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btt8M-0007IH-Fe for bug-guile@gnu.org; Tue, 11 Oct 2016 05:14:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btt8M-0007ID-CH for bug-guile@gnu.org; Tue, 11 Oct 2016 05:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1btt8M-0000w1-86 for bug-guile@gnu.org; Tue, 11 Oct 2016 05:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 11 Oct 2016 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24659 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 24659-submit@debbugs.gnu.org id=B24659.14761772223560 (code B ref 24659); Tue, 11 Oct 2016 09:14:02 +0000 Original-Received: (at 24659) by debbugs.gnu.org; 11 Oct 2016 09:13:42 +0000 Original-Received: from localhost ([127.0.0.1]:51717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btt7y-0000vH-T8 for submit@debbugs.gnu.org; Tue, 11 Oct 2016 05:13:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btt7t-0000uy-Cw for 24659@debbugs.gnu.org; Tue, 11 Oct 2016 05:13:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btt7j-0006zd-LS for 24659@debbugs.gnu.org; Tue, 11 Oct 2016 05:13:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btt7j-0006zZ-IL; Tue, 11 Oct 2016 05:13:23 -0400 Original-Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:60162 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1btt7i-0000Ge-Sh; Tue, 11 Oct 2016 05:13:23 -0400 In-Reply-To: <20161010182537.GA27089@tuxteam.de> (tomas@tuxteam.de's message of "Mon, 10 Oct 2016 20:25:37 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8425 Archived-At: Hi, skribis: > On Mon, Oct 10, 2016 at 06:39:47PM +0200, Ludovic Court=C3=A8s wrote: >> Hello! > > [...] > >> Furthermore, AFAICS, the above logic is redundant with what the kernel >> does anyway. That is, in a single-threaded program, >> >> mask =3D umask (0); >> umask (mask); >> mkdir (file, 0777 ^ mask); >> >> is equivalent to: >> >> mkdir (file, 0777); >> >> Am I right that we should just remove these two =E2=80=98umask=E2=80=99 = calls? > > According to umask(2), yes, you are right. Unless someone has been > trying to work around some platform-specific bug/idiosyncracy. I don=E2=80=99t think there was ever a good reason for this. Fixed in 245608911698adb3472803856019bdd5670b6614. Thanks for your feedback, Ludo=E2=80=99.