From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#29162: [PATCH] fix scm_make_foreign_object_n Date: Wed, 22 Nov 2017 16:12:24 +0100 Message-ID: <871skqz6sn.fsf@gnu.org> References: <20171105221510.12760-1-slyfox@gentoo.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1511363594 23512 195.159.176.226 (22 Nov 2017 15:13:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 15:13:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: 29162@debbugs.gnu.org To: Sergei Trofimovich Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Nov 22 16:13:10 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHWi2-0005d2-AA for guile-bugs@m.gmane.org; Wed, 22 Nov 2017 16:13:06 +0100 Original-Received: from localhost ([::1]:39995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHWi9-0003rG-EO for guile-bugs@m.gmane.org; Wed, 22 Nov 2017 10:13:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHWi3-0003r9-Ov for bug-guile@gnu.org; Wed, 22 Nov 2017 10:13:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHWhy-0001Ja-M3 for bug-guile@gnu.org; Wed, 22 Nov 2017 10:13:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHWhy-0001JW-I1 for bug-guile@gnu.org; Wed, 22 Nov 2017 10:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eHWhy-0006zH-Ae for bug-guile@gnu.org; Wed, 22 Nov 2017 10:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 22 Nov 2017 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29162 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 29162-submit@debbugs.gnu.org id=B29162.151136354926810 (code B ref 29162); Wed, 22 Nov 2017 15:13:02 +0000 Original-Received: (at 29162) by debbugs.gnu.org; 22 Nov 2017 15:12:29 +0000 Original-Received: from localhost ([127.0.0.1]:52846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHWhR-0006yM-0V for submit@debbugs.gnu.org; Wed, 22 Nov 2017 10:12:29 -0500 Original-Received: from hera.aquilenet.fr ([141.255.128.1]:60555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHWhO-0006yE-Ub for 29162@debbugs.gnu.org; Wed, 22 Nov 2017 10:12:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id A733AFE3C; Wed, 22 Nov 2017 16:12:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Original-Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yW6CFz__TwEZ; Wed, 22 Nov 2017 16:12:27 +0100 (CET) Original-Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 13C0AF3C9; Wed, 22 Nov 2017 16:12:27 +0100 (CET) In-Reply-To: <20171105221510.12760-1-slyfox@gentoo.org> (Sergei Trofimovich's message of "Sun, 5 Nov 2017 22:15:10 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8896 Archived-At: Hi Sergei, Sergei Trofimovich skribis: > diff --git a/libguile/foreign-object.c b/libguile/foreign-object.c > index 34b9f22ca..8fd2c384c 100644 > --- a/libguile/foreign-object.c > +++ b/libguile/foreign-object.c > @@ -108,7 +108,7 @@ scm_make_foreign_object_n (SCM type, size_t n, void *= vals[]) >=20=20 > SCM_VALIDATE_VTABLE (SCM_ARG1, type); >=20=20 > - if (SCM_VTABLE_SIZE (type) / 2 < n) > + if (SCM_VTABLE_SIZE (type) < n) > scm_out_of_range (FUNC_NAME, scm_from_size_t (n)); Your analysis seems right, but the code in the current =E2=80=98stable-2.2= =E2=80=99 branch (which corresponds to the 2.2.x stable series) has different code (correct code): SCM_VALIDATE_VTABLE (SCM_ARG1, type); layout =3D SCM_VTABLE_LAYOUT (type); if (scm_i_symbol_length (layout) / 2 < n) scm_out_of_range (FUNC_NAME, scm_from_size_t (n)); What version were you looking at? Thanks, Ludo=E2=80=99.