bug#32040: Potential REPL Server Bug (with a Patch)

bug#32040: Potential REPL Server Bug (with a Patch)

[isaac lewis]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

Good afternoon,

I experienced some issues on both Debian and Fedora a while ago with
the REPL server module.  After searching the bug database, I didn't
find any similar reports, so I decided to investigate the issues a bit
more and found that they appear to be caused by a non-idiomatic use of
dynamic-wind (that was likely the result of a typo).  A patch is
given below.

Sincerely,

Isaac Lewis

From 6dedc1a6d64ecbf6f1c9a4e60a6ea4a46c5b55ff Mon Sep 17 00:00:00 2001
From: Isaac Lewis <isaac.b.lewis@gmail.com>
Date: Mon, 2 Jul 2018 11:37:27 -0400
Subject: [PATCH] Fix a bug in the REPL server.

---
 module/system/repl/server.scm | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/module/system/repl/server.scm b/module/system/repl/server.scm
index 725eb4e..f18441d 100644
--- a/module/system/repl/server.scm
+++ b/module/system/repl/server.scm
@@ -146,14 +146,15 @@

   (dynamic-wind
     (lambda () #f)
-    (with-continuation-barrier
-     (lambda ()
-       (parameterize ((current-input-port client)
-                      (current-output-port client)
-                      (current-error-port client)
-                      (current-warning-port client))
-         (with-fluids ((*repl-stack* '()))
-           (start-repl)))))
+    (lambda ()
+      (with-continuation-barrier
+       (lambda ()
+         (parameterize ((current-input-port client)
+                        (current-output-port client)
+                        (current-error-port client)
+                        (current-warning-port client))
+                       (with-fluids ((*repl-stack* '()))
+                                    (start-repl))))))
     (lambda () (close-socket! client))))


-- 
2.9.5

[-- Attachment #2: Type: text/html, Size: 2232 bytes --]

bug#32040: bug in repl/server.scm

[Matt Wette]

I can confirm this still exists in guile 3.0.8:
The symptom that I see is when client (telnet localhost 37146)
quits server responds with the following:

    In thread:
   Wrong type to apply: ()

  Nice find Isaac!