From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Tam Newsgroups: gmane.lisp.guile.bugs Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled Date: Fri, 24 Aug 2018 22:42:40 +1000 Message-ID: <7e908c7a-4e02-13c4-c09b-78bedc805cf6@gmail.com> References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@gmail.com> <87pny9by7s.fsf@netris.org> <87tvnkcon3.fsf@netris.org> <87mutccn2l.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1535114525 3580 195.159.176.226 (24 Aug 2018 12:42:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Aug 2018 12:42:05 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: 32501@debbugs.gnu.org To: Mark H Weaver Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Aug 24 14:42:01 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftBPc-0000me-Vk for guile-bugs@m.gmane.org; Fri, 24 Aug 2018 14:42:01 +0200 Original-Received: from localhost ([::1]:41585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftBRj-0001PV-8X for guile-bugs@m.gmane.org; Fri, 24 Aug 2018 08:44:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftBRe-0001PF-C7 for bug-guile@gnu.org; Fri, 24 Aug 2018 08:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftBRa-00065I-BV for bug-guile@gnu.org; Fri, 24 Aug 2018 08:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ftBRa-00064w-7D for bug-guile@gnu.org; Fri, 24 Aug 2018 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ftBRa-0004JB-50 for bug-guile@gnu.org; Fri, 24 Aug 2018 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Tam Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 24 Aug 2018 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32501 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 32501-submit@debbugs.gnu.org id=B32501.153511458216487 (code B ref 32501); Fri, 24 Aug 2018 12:44:02 +0000 Original-Received: (at 32501) by debbugs.gnu.org; 24 Aug 2018 12:43:02 +0000 Original-Received: from localhost ([127.0.0.1]:59406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftBQc-0004Hr-Ax for submit@debbugs.gnu.org; Fri, 24 Aug 2018 08:43:02 -0400 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:42449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftBQa-0004HN-Su for 32501@debbugs.gnu.org; Fri, 24 Aug 2018 08:43:01 -0400 Original-Received: by mail-pl1-f170.google.com with SMTP id g23-v6so1060813plq.9 for <32501@debbugs.gnu.org>; Fri, 24 Aug 2018 05:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+gsbZYzk/ZEFzPx9pVn10nXHkZvbp2gFX+GXNZ1ouSQ=; b=XAUdHbSP4GiwZPzRRUsB55+xmC4DRSCVy1MarJd37ydo9qCpTErLvl8jym/Vi9gd/D SoNEIEKl7jr0gBd8mArhYG/5Vpt+RfD2CeT0fXOIJDj0rRpVEDEStZSnWRl0e1O21Fe9 kEJUDlARyG+VmzSZTGCb4ZERWxg+hsUf1SK0HGmTb3DuFJDFrMl6E4/A4eggaVXCiRbB z3BMkDhmCLeaD4JLI3XPkurdBZ6QjXQMyvo4YG50NOC/9dI/F3Zt+3KA7u/pu6fiLgLW c+i/IqVWp0umCHJ6jNNBP2chIDsuAn0RZqM3ywf+LvIanJVQL7PRxB0GMkk8RK4A0Ohl Db8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+gsbZYzk/ZEFzPx9pVn10nXHkZvbp2gFX+GXNZ1ouSQ=; b=rlRTKbl0IfkuCxPhi8m7I+M3g0tibJWE/bT3CS49GLzqcHmn3KIDyquS83G8mC8VP7 EjE5AoX6DmBW794mRpWby4CB6OH5v7/zptpbtBVn+OMw3kPiLxx/7msY0wqL82jvJCVw Z0HoQHF7monKgkI3Roc072ePLfeceV6fEhXNTYn27KIfjX9F0Ng12AI8Dq9opMmN7GAq zFpM2Se526ObLF3L79lQP7EHjIXMMUQ8Gdmrah3dyhnVNWG4GY0WgCH11qAUexWCtEnz YNFYkdq9gHL3OWAHFKf4a2lqt3Az6OmWEDlCWTN51PO97WtASBepFczOD8NxQZR0zaZG eLmA== X-Gm-Message-State: APzg51CPvoktopkMGrH+I/yHtE+FlRgo6qfV6HoisVA+4QREwHk6Ptlf d/IsGWL9ZaGYU/6+3uqInrFzHv9dN+k= X-Google-Smtp-Source: ANB0VdalCTvps0HKTAJp/8qTo4jyW9LMKnqajzodmjILfmq+yIaSwoReVPz4QVtLxK/Fif+JkDbiDA== X-Received: by 2002:a17:902:5a49:: with SMTP id f9-v6mr1592687plm.332.1535114574822; Fri, 24 Aug 2018 05:42:54 -0700 (PDT) Original-Received: from [192.168.1.100] (ppp121-44-111-137.bras1.syd7.internode.on.net. [121.44.111.137]) by smtp.gmail.com with ESMTPSA id a2-v6sm8268963pgc.68.2018.08.24.05.42.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Aug 2018 05:42:54 -0700 (PDT) In-Reply-To: <87mutccn2l.fsf@netris.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9135 Archived-At: Hey Mark, On 08/24/2018 04:09 PM, Mark H Weaver wrote: > I wrote: > >>> The right fix might be to simply remove the 'if' check above. >> Actually, it probably won't be that simple. Whereas in emacs mode, we= >> can probably rely on these bindings being added to the correct keymap,= >> namely 'emacs_standard_keymap', when in vi mode it's likely that these= >> bindings would end up in the wrong keymap, namely 'vi_movement_keymap'= =2E >> >> When in vi mode, these mappings should be added to >> 'vi_insertion_keymap', and that probably involves using >> 'rl_bind_key_in_map' instead of 'rl_bind_key'. > And I guess 'rl_get_keymap_by_name' is the function we should use to ge= t > the keymap. From keymaps.h in readline: > > /* Return the keymap corresponding to a given name. Names look like > `emacs' or `emacs-meta' or `vi-insert'. */ > extern Keymap rl_get_keymap_by_name PARAMS((const char *)); > > Mark I'm excited to have a look but I have 0 knowledge of the code base (and am just learning Scheme although that's probably not an issue in this case whatsoever). Do you have any advice for specific documentation/files (other than README and HACKING) that I should read if I were to attempt this? As well as which branch to base my changes ont= o. Daniel