From: Daniel Tam <danooo.tam@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: 32501@debbugs.gnu.org
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Date: Fri, 24 Aug 2018 22:42:40 +1000 [thread overview]
Message-ID: <7e908c7a-4e02-13c4-c09b-78bedc805cf6@gmail.com> (raw)
In-Reply-To: <87mutccn2l.fsf@netris.org>
Hey Mark,
On 08/24/2018 04:09 PM, Mark H Weaver wrote:
> I wrote:
>
>>> The right fix might be to simply remove the 'if' check above.
>> Actually, it probably won't be that simple. Whereas in emacs mode, we
>> can probably rely on these bindings being added to the correct keymap,
>> namely 'emacs_standard_keymap', when in vi mode it's likely that these
>> bindings would end up in the wrong keymap, namely 'vi_movement_keymap'.
>>
>> When in vi mode, these mappings should be added to
>> 'vi_insertion_keymap', and that probably involves using
>> 'rl_bind_key_in_map' instead of 'rl_bind_key'.
> And I guess 'rl_get_keymap_by_name' is the function we should use to get
> the keymap. From keymaps.h in readline:
>
> /* Return the keymap corresponding to a given name. Names look like
> `emacs' or `emacs-meta' or `vi-insert'. */
> extern Keymap rl_get_keymap_by_name PARAMS((const char *));
>
> Mark
I'm excited to have a look but I have 0 knowledge of the code base (and
am just learning Scheme although that's probably not an issue in this
case whatsoever). Do you have any advice for specific
documentation/files (other than README and HACKING) that I should read
if I were to attempt this? As well as which branch to base my changes onto.
Daniel
next prev parent reply other threads:[~2018-08-24 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 15:47 bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled Daniel Tam
2018-08-23 2:42 ` Mark H Weaver
2018-08-23 4:03 ` Mark H Weaver
2018-08-23 16:13 ` John Cowan
2018-08-24 5:36 ` Mark H Weaver
2018-08-24 6:09 ` Mark H Weaver
2018-08-24 12:42 ` Daniel Tam [this message]
2018-08-24 22:11 ` Mark H Weaver
2022-07-11 12:20 ` bug#32501: Bug #32501 - " Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e908c7a-4e02-13c4-c09b-78bedc805cf6@gmail.com \
--to=danooo.tam@gmail.com \
--cc=32501@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).