From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom de Vries Newsgroups: gmane.lisp.guile.bugs Subject: bug#33044: Guile misbehaves in the "ja_JP.sjis" locale Date: Thu, 18 Oct 2018 12:26:12 +0200 Message-ID: <673d7121-9d70-5856-511d-2e9c4ef49ec9@suse.de> References: <469f2345-5e76-1fc5-1105-f1d508611140@suse.de> <8a6a308f-a981-fd46-93d5-c2d2870f4eb4@suse.de> <87y3ayodqp.fsf_-_@netris.org> <25e93980-834d-cf91-cabf-77c2bb9a31c5@suse.de> <871s8o10h6.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1539858310 2712 195.159.176.226 (18 Oct 2018 10:25:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2018 10:25:10 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 Cc: 33044@debbugs.gnu.org To: Mark H Weaver Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Oct 18 12:25:06 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD5UE-0000XP-U8 for guile-bugs@m.gmane.org; Thu, 18 Oct 2018 12:25:03 +0200 Original-Received: from localhost ([::1]:41509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD5WL-0007xD-EH for guile-bugs@m.gmane.org; Thu, 18 Oct 2018 06:27:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD5WF-0007wv-CE for bug-guile@gnu.org; Thu, 18 Oct 2018 06:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gD5WA-000736-9G for bug-guile@gnu.org; Thu, 18 Oct 2018 06:27:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gD5WA-00072f-1i for bug-guile@gnu.org; Thu, 18 Oct 2018 06:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gD5W9-0003oJ-O5 for bug-guile@gnu.org; Thu, 18 Oct 2018 06:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom de Vries Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 18 Oct 2018 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33044 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 33044-submit@debbugs.gnu.org id=B33044.153985837214578 (code B ref 33044); Thu, 18 Oct 2018 10:27:01 +0000 Original-Received: (at 33044) by debbugs.gnu.org; 18 Oct 2018 10:26:12 +0000 Original-Received: from localhost ([127.0.0.1]:56141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD5VM-0003n4-5H for submit@debbugs.gnu.org; Thu, 18 Oct 2018 06:26:12 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:49768 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD5VK-0003mp-5I for 33044@debbugs.gnu.org; Thu, 18 Oct 2018 06:26:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 49324B0B4; Thu, 18 Oct 2018 10:26:04 +0000 (UTC) In-Reply-To: <871s8o10h6.fsf@netris.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9210 Archived-At: On 10/18/18 3:56 AM, Mark H Weaver wrote: > Hi Tom, > > Tom de Vries writes: > >> On 10/16/18 3:57 AM, Mark H Weaver wrote: >>> Thanks for the report, analysis and patch. I agree with your analysis, >>> and the patch looks good. >>> >> >> If so, can the patch be committed? > > I just pushed commit c2a654b7d29f5e2f32fd1313cc80162fd0c8f992 to the > stable-2.2 branch, Thanks! > which includes the fix from your patch (although I > used 'scm_from_utf8_string' instead of 'scm_from_latin1_string'), Right, that should give the same result on that string. > and > many other instances of the same problem. These fixes will be in the > upcoming guile-2.2.5 release. > > Does that address the problem for you? > There are two pecularities I'm affected by: - I'm not able to build from git (and I haven't found instructions listing in the README what the correct auto* invocation is). So, tarballs only. - gdb does not support guile 2.2 (so I'd need a backport of this fix to stable-2.0 branch). See also "PR21104 - 7.12.1 does not compile with latest guile (2.1.6)" ( https://sourceware.org/bugzilla/show_bug.cgi?id=21104 ). As for testing, I've done the following: - applied the patch onto the 2.2 tarball, build and ran tests, and ran hello.scm reproducer - ported the patch to the 2.0 tarball, build and ran tests, and ran hello.scm reproducer - build gdb master against the the 2.0 tarball build, ran gdb guile tests, and ran the gdb reproducer. This is as far as I can take it, and all LGTM. Thanks, - Tom > I'll leave this bug open at least until 'seed->random-state your-seed' > is fixed to support wide strings. > > Thanks again, > > Mark >