From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lloda Newsgroups: gmane.lisp.guile.bugs Subject: bug#73605: [PATCH] Replace SRFI-64 with a new implementation. Date: Sat, 26 Oct 2024 20:09:46 +0200 Message-ID: <618AA602-0EBB-48E4-8BF2-08787AE63F1A@sarc.name> References: <20241002194105.24409-1-~@wolfsden.cz> <87o73nrchr.fsf@gnu.org> <875xpmlgps.fsf@gnu.org> <09A9A831-0334-4109-823D-71FF335EBA75@sarc.name> <875xpf0zkr.fsf@gnu.org> <874j4zklar.fsf@wolfsden.cz> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73605@debbugs.gnu.org To: Tomas Volf <~@wolfsden.cz> Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sat Oct 26 20:11:13 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t4lFo-0000x0-Rp for guile-bugs@m.gmane-mx.org; Sat, 26 Oct 2024 20:11:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4lF9-0000G5-Jp; Sat, 26 Oct 2024 14:10:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4lF7-0000FS-EJ for bug-guile@gnu.org; Sat, 26 Oct 2024 14:10:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t4lF7-00064J-5l for bug-guile@gnu.org; Sat, 26 Oct 2024 14:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=nUw7HhfC1JHql2VrjOgM7+MAuyN42LlAyHzhc7PKydY=; b=AjwEes0SCGSjfbBWen4vi+CCHPVnTzj56QmW/nrEB3dRXuA5Bs2KqsHVCwqDI3F80rl4hbDXPTXcN+Iac4qKgPQee5DQfHxvkm3w7l8PdGkRLME1OTA5BJQ7HVh2Ip0fcjLnINozOl5mW0q5nj56p9VVygfAPkrakhj91ZLjd7yMARwbtS5uHp5AtiKDXgUDXY3rMk2FyVGZmO7CM3XnNXqzQOK/KAZ8vmdXfAMq0eOT6O7A8+RjB1FIXSWL3xtCFnyK9OXDwHhAnte/JOrWbVrKvZHfIpKOoqpaOegz1ywTdfStvRoZgFU+k1byaeRIfP4xV9xJiPJLzCLwnqRLRA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t4lFe-0002WZ-Ho for bug-guile@gnu.org; Sat, 26 Oct 2024 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: lloda Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 26 Oct 2024 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73605 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 73605-submit@debbugs.gnu.org id=B73605.17299662339277 (code B ref 73605); Sat, 26 Oct 2024 18:11:02 +0000 Original-Received: (at 73605) by debbugs.gnu.org; 26 Oct 2024 18:10:33 +0000 Original-Received: from localhost ([127.0.0.1]:42538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4lFB-0002PY-12 for submit@debbugs.gnu.org; Sat, 26 Oct 2024 14:10:33 -0400 Original-Received: from mta-06-4.privateemail.com ([198.54.122.146]:40233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4lF9-0002PI-CO for 73605@debbugs.gnu.org; Sat, 26 Oct 2024 14:10:32 -0400 Original-Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 06F2118000B5; Sat, 26 Oct 2024 14:09:52 -0400 (EDT) Original-Received: from [192.168.1.16] (unknown [51.154.167.214]) by mta-06.privateemail.com (Postfix) with ESMTPA; Sat, 26 Oct 2024 14:09:48 -0400 (EDT) In-Reply-To: <874j4zklar.fsf@wolfsden.cz> X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:11084 Archived-At: > On 26 Oct 2024, at 16:09, Tomas Volf <~@wolfsden.cz> wrote: >>> * test-approximate requires real arguments. The old version accepted = complex arguments. >=20 > No objections, since it seems that (imag-part 0) works just fine, I = can > basically rewrite it to always consider the input complex, and it will > work. I think just changing within-epsilon to check (<=3D (magnitude (- = expected value)) epsilon) would work. While looking at this I noticed that 1) the default test runner doesn't = print either the computed error or the specified error and 2) = test-approximate doesn't store the computed error in the test result (it = does store the specified error). This makes it difficult for a custom test runner to print these things. = I think test-approximate should store the computed error and also that = these properties should be documented, so user-defined test routines (to = compare other types) can use them as well.=20 >>> * The exported variable test-log-to-file is gone. >=20 > I oppose to restoring this one. When you loaded test file into REPL, = it > used to just litter your file system with random test log files = created > in whatever the current working directory is. I do not consider that = to > be a good behavior. I don't think the variable should be restored. I also think that if the = option were to be offered in a different way, not writing files is the = better default. However, users who relied on the variable should not = lose functionality. Perhaps add an argument to the default runner? Regards lloda