* bug#45131: guild fails to compile a Tree-IL file
@ 2020-12-09 12:05 Tommi Höynälänmaa
2020-12-29 18:09 ` bug#45131: [PATCH] Compile directly to target language if no joint is found Leo Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Tommi Höynälänmaa @ 2020-12-09 12:05 UTC (permalink / raw)
To: 45131
[-- Attachment #1.1.1: Type: text/plain, Size: 1988 bytes --]
This bug occurs in both guile version 3.0.4.38-64c894 and
3.0.4-1.2ubuntu3. I use Ubuntu 20.10.
*** Steps to reproduce ***
1. Create file hello1.scm with the following contents:
---cut here---
(display "Hello world")
(newline)
---cut here---
2. Give command
guild compile --to=tree-il -o hello1.tree-il hello1.scm
3. Give command
guild compile --from=tree-il -o hello1.go hello1.tree-il
*** Expected output ***
File hello1.tree-il should be compiled to hello1.go
*** Actual output ***
---cut here---
Backtrace:
In /home/tohoyn/git/other/guile/meta/guild:
72:17 19 (main _)
In srfi/srfi-1.scm:
634:9 18 (for-each #<procedure 7fa5b08eb6e0 at scripts/compile.…> …)
In scripts/compile.scm:
279:26 17 (_ _)
In system/base/target.scm:
65:6 16 (with-target _ _)
In system/base/compile.scm:
187:6 15 (compile-file "hello1.tree-il" #:output-file _ #:from _ …)
53:4 14 (call-with-output-file/atomic _ _ _)
In ice-9/boot-9.scm:
1736:10 13 (with-exception-handler _ _ #:unwind? _ # _)
In system/base/compile.scm:
69:11 12 (_)
190:11 11 (_ #<closed: file 7fa5af3990e0>)
335:18 10 (read-and-compile #<input: hello1.tree-il 13> #:from _ # …)
84:6 9 (compute-compiler _ #f 2 1 (#:to-file? #t #:warnings #))
In system/base/language.scm:
63:11 8 (lookup-language #f)
In ice-9/threads.scm:
390:8 7 (_ _)
In ice-9/boot-9.scm:
3223:13 6 (_)
3493:26 5 (try-module-autoload _ _)
222:29 4 (map1 (language #f))
222:17 3 (map1 (#f))
3494:48 2 (_ _)
In unknown file:
1 (symbol->string #f)
In ice-9/boot-9.scm:
1669:16 0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1669:16: In procedure raise-exception:
In procedure symbol->string: Wrong type argument in position 1
(expecting symbol): #f
---cut here---
- Tommi Höynälänmaa
[-- Attachment #1.1.2: OpenPGP_0xBB861FDE40460F83.asc --]
[-- Type: application/pgp-keys, Size: 3199 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#45131: [PATCH] Compile directly to target language if no joint is found.
2020-12-09 12:05 bug#45131: guild fails to compile a Tree-IL file Tommi Höynälänmaa
@ 2020-12-29 18:09 ` Leo Prikler
2021-05-10 8:17 ` bug#45131: guild fails to compile a Tree-IL file Andy Wingo
0 siblings, 1 reply; 3+ messages in thread
From: Leo Prikler @ 2020-12-29 18:09 UTC (permalink / raw)
To: 45131; +Cc: tommi.hoynalanmaa
This enables the compilation from "manually" written Tree-IL to
bytecode. See also <https://bugs.gnu.org/45131>.
* system/base/compile.scm (read-and-compile)[(joint #f)]<? eof-object?>:
Join exps using the default joiner for to.
<exp>: Compute compiler for to.
* test-suite/test/compiler.test ("read-and-compile tree-il"): New test.
---
module/system/base/compile.scm | 26 +++++++++++++++-----------
test-suite/tests/compiler.test | 22 ++++++++++++++++++++++
2 files changed, 37 insertions(+), 11 deletions(-)
diff --git a/module/system/base/compile.scm b/module/system/base/compile.scm
index 567765dc0..41ad0158a 100644
--- a/module/system/base/compile.scm
+++ b/module/system/base/compile.scm
@@ -310,16 +310,20 @@
(match (read-and-parse (current-language) port cenv)
((? eof-object?)
(close-port port)
- (compile ((or (language-joiner joint)
- (default-language-joiner joint))
- (reverse exps)
- env)
- #:from joint #:to to
- ;; env can be false if no expressions were read.
- #:env (or env (default-environment joint))
- #:optimization-level optimization-level
- #:warning-level warning-level
- #:opts opts))
+ (if joint
+ (compile ((or (language-joiner joint)
+ (default-language-joiner joint))
+ (reverse exps)
+ env)
+ #:from joint #:to to
+ ;; env can be false if no expressions were read.
+ #:env (or env (default-environment joint))
+ #:optimization-level optimization-level
+ #:warning-level warning-level
+ #:opts opts)
+ ((default-language-joiner to)
+ (reverse exps)
+ env)))
(exp
(let with-compiler ((from from) (compile1 compile1))
(cond
@@ -332,7 +336,7 @@
(let ((from (current-language)))
(with-compiler
from
- (compute-compiler from joint optimization-level
+ (compute-compiler from (or joint to) optimization-level
warning-level opts))))))))))))
(define* (compile x #:key
diff --git a/test-suite/tests/compiler.test b/test-suite/tests/compiler.test
index dc75d0ac7..cdc26c751 100644
--- a/test-suite/tests/compiler.test
+++ b/test-suite/tests/compiler.test
@@ -337,3 +337,25 @@
(pass-if-equal "test terminates without error" 42
(test-proc)))
+(with-test-prefix "read-and-compile tree-il"
+ (let ((code
+ "\
+(seq
+ (define forty-two
+ (lambda ((name . forty-two))
+ (lambda-case ((() #f #f #f () ()) (const 42)))))
+ (toplevel forty-two))")
+ (bytecode #f)
+ (proc #f))
+ (pass-if "compiling tree-il works"
+ (begin
+ (set! bytecode
+ (call-with-input-string code
+ (lambda (port)
+ (read-and-compile port #:from 'tree-il))))
+ #t))
+ (pass-if "bytecode can be read"
+ (begin
+ (set! proc ((load-thunk-from-memory bytecode)))
+ (procedure? proc)))
+ (pass-if-equal "proc executes" 42 (proc))))
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* bug#45131: guild fails to compile a Tree-IL file
2020-12-29 18:09 ` bug#45131: [PATCH] Compile directly to target language if no joint is found Leo Prikler
@ 2021-05-10 8:17 ` Andy Wingo
0 siblings, 0 replies; 3+ messages in thread
From: Andy Wingo @ 2021-05-10 8:17 UTC (permalink / raw)
To: Leo Prikler; +Cc: 45131-done, tommi.hoynalanmaa
Thanks for the patch; applied!
Andy
On Tue 29 Dec 2020 19:09, Leo Prikler <leo.prikler@student.tugraz.at> writes:
> This enables the compilation from "manually" written Tree-IL to
> bytecode. See also <https://bugs.gnu.org/45131>.
>
> * system/base/compile.scm (read-and-compile)[(joint #f)]<? eof-object?>:
> Join exps using the default joiner for to.
> <exp>: Compute compiler for to.
> * test-suite/test/compiler.test ("read-and-compile tree-il"): New test.
> ---
> module/system/base/compile.scm | 26 +++++++++++++++-----------
> test-suite/tests/compiler.test | 22 ++++++++++++++++++++++
> 2 files changed, 37 insertions(+), 11 deletions(-)
>
> diff --git a/module/system/base/compile.scm b/module/system/base/compile.scm
> index 567765dc0..41ad0158a 100644
> --- a/module/system/base/compile.scm
> +++ b/module/system/base/compile.scm
> @@ -310,16 +310,20 @@
> (match (read-and-parse (current-language) port cenv)
> ((? eof-object?)
> (close-port port)
> - (compile ((or (language-joiner joint)
> - (default-language-joiner joint))
> - (reverse exps)
> - env)
> - #:from joint #:to to
> - ;; env can be false if no expressions were read.
> - #:env (or env (default-environment joint))
> - #:optimization-level optimization-level
> - #:warning-level warning-level
> - #:opts opts))
> + (if joint
> + (compile ((or (language-joiner joint)
> + (default-language-joiner joint))
> + (reverse exps)
> + env)
> + #:from joint #:to to
> + ;; env can be false if no expressions were read.
> + #:env (or env (default-environment joint))
> + #:optimization-level optimization-level
> + #:warning-level warning-level
> + #:opts opts)
> + ((default-language-joiner to)
> + (reverse exps)
> + env)))
> (exp
> (let with-compiler ((from from) (compile1 compile1))
> (cond
> @@ -332,7 +336,7 @@
> (let ((from (current-language)))
> (with-compiler
> from
> - (compute-compiler from joint optimization-level
> + (compute-compiler from (or joint to) optimization-level
> warning-level opts))))))))))))
>
> (define* (compile x #:key
> diff --git a/test-suite/tests/compiler.test b/test-suite/tests/compiler.test
> index dc75d0ac7..cdc26c751 100644
> --- a/test-suite/tests/compiler.test
> +++ b/test-suite/tests/compiler.test
> @@ -337,3 +337,25 @@
> (pass-if-equal "test terminates without error" 42
> (test-proc)))
>
> +(with-test-prefix "read-and-compile tree-il"
> + (let ((code
> + "\
> +(seq
> + (define forty-two
> + (lambda ((name . forty-two))
> + (lambda-case ((() #f #f #f () ()) (const 42)))))
> + (toplevel forty-two))")
> + (bytecode #f)
> + (proc #f))
> + (pass-if "compiling tree-il works"
> + (begin
> + (set! bytecode
> + (call-with-input-string code
> + (lambda (port)
> + (read-and-compile port #:from 'tree-il))))
> + #t))
> + (pass-if "bytecode can be read"
> + (begin
> + (set! proc ((load-thunk-from-memory bytecode)))
> + (procedure? proc)))
> + (pass-if-equal "proc executes" 42 (proc))))
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-10 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 12:05 bug#45131: guild fails to compile a Tree-IL file Tommi Höynälänmaa
2020-12-29 18:09 ` bug#45131: [PATCH] Compile directly to target language if no joint is found Leo Prikler
2021-05-10 8:17 ` bug#45131: guild fails to compile a Tree-IL file Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).