From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Blake Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.lisp.guile.bugs Subject: Re: -Wundef warning in striconveh.h Date: Thu, 17 Mar 2011 08:05:17 -0600 Organization: Red Hat Message-ID: <4D82151D.50303@redhat.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigAEBD76E2B8D7BE861C24E7E2" X-Trace: dough.gmane.org 1300370733 11937 80.91.229.12 (17 Mar 2011 14:05:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Mar 2011 14:05:33 +0000 (UTC) Cc: bug-guile@gnu.org, bug-gnulib@gnu.org To: Andy Wingo Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Thu Mar 17 15:05:29 2011 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0DpQ-0007pv-4L for gnu-bug-gnulib@m.gmane.org; Thu, 17 Mar 2011 15:05:28 +0100 Original-Received: from localhost ([127.0.0.1]:45433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0DpP-0004hV-Ik for gnu-bug-gnulib@m.gmane.org; Thu, 17 Mar 2011 10:05:27 -0400 Original-Received: from [140.186.70.92] (port=42552 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0DpI-0004hQ-T9 for bug-gnulib@gnu.org; Thu, 17 Mar 2011 10:05:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0DpH-00056H-S7 for bug-gnulib@gnu.org; Thu, 17 Mar 2011 10:05:20 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:37037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0DpH-00056B-C3; Thu, 17 Mar 2011 10:05:19 -0400 Original-Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2HE5Iui004095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Mar 2011 10:05:18 -0400 Original-Received: from [10.3.113.32] (ovpn-113-32.phx2.redhat.com [10.3.113.32]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2HE5Hqp015365; Thu, 17 Mar 2011 10:05:17 -0400 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 In-Reply-To: X-Enigmail-Version: 1.1.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:25674 gmane.lisp.guile.bugs:5332 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAEBD76E2B8D7BE861C24E7E2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/17/2011 04:20 AM, Andy Wingo wrote: > Hello, >=20 > striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef= , > or something. Not a bug in gnulib, >=20 > Building Guile a contributor got this warning: but in guile. Gnulib specifically documents that -Wundef is incompatible with gnulib modules, and that our coding style is deliberate. -Wundef only catches portability problems for ancient (non-C89) compilers, and gnulib requires C89 as a bare minimum. While you are free to use it for the rest of your project, you need to avoid it while compiling gnulib (or at least ignore the warnings and avoid -Werror). The coreutils project demonstrates how to have two different set of warning flags appended to AM_CFLAGS: a looser set for the gnulib subdirectory, and a stricter set for the rest of the project. --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enigAEBD76E2B8D7BE861C24E7E2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJNghUdAAoJEKeha0olJ0NqHycH/RpnZYktQIfckBCTS003Jo4u pvMms/1UtumiGboqkZZ7l6WcwrVWoaPTnRyGtXGl8Ebs8wFDeeD0KKXN3ppW4BFg WZANwtWmnp3mUnqwRf9pf7WIWy0b8GqaIxuc3NZa70Z6QF1dC/pKLBPhttZI9vuS H/H2lET2jqMheaLyzUBcqniRniBsAXX1wpyKpzT2RMDsUHvEC7jJaLSW9qX3G14g M+zhGtkSMslqhn6falG4GmZXDSXVsln/mzWCeOEtvU7aHge/M2hMf/wlO9d27z7l wfZUlE+jrEnIJ+GuHObXgsdoVDPAhjIIoUPlP/9JHtec2vFM9dye+A7Gu4w4ptw= =dVRz -----END PGP SIGNATURE----- --------------enigAEBD76E2B8D7BE861C24E7E2--