From: Eric Blake <eblake@redhat.com>
To: Andy Wingo <wingo@pobox.com>
Cc: bug-guile@gnu.org, bug-gnulib@gnu.org
Subject: Re: -Wundef warning in striconveh.h
Date: Thu, 17 Mar 2011 08:05:17 -0600 [thread overview]
Message-ID: <4D82151D.50303@redhat.com> (raw)
In-Reply-To: <m3fwqm120t.fsf@unquote.localdomain>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On 03/17/2011 04:20 AM, Andy Wingo wrote:
> Hello,
>
> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef,
> or something.
Not a bug in gnulib,
>
> Building Guile a contributor got this warning:
but in guile. Gnulib specifically documents that -Wundef is
incompatible with gnulib modules, and that our coding style is
deliberate. -Wundef only catches portability problems for ancient
(non-C89) compilers, and gnulib requires C89 as a bare minimum. While
you are free to use it for the rest of your project, you need to avoid
it while compiling gnulib (or at least ignore the warnings and avoid
-Werror).
The coreutils project demonstrates how to have two different set of
warning flags appended to AM_CFLAGS: a looser set for the gnulib
subdirectory, and a stricter set for the rest of the project.
--
Eric Blake eblake@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2011-03-17 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 10:20 -Wundef warning in striconveh.h Andy Wingo
2011-03-17 14:05 ` Eric Blake [this message]
2011-03-17 14:46 ` Andy Wingo
2011-03-17 16:15 ` Paul Eggert
2011-03-17 17:03 ` Andy Wingo
2011-04-25 21:35 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D82151D.50303@redhat.com \
--to=eblake@redhat.com \
--cc=bug-gnulib@gnu.org \
--cc=bug-guile@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).