From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Peter O'Gorman Newsgroups: gmane.lisp.guile.bugs,gmane.comp.gnu.libtool.patches Subject: Re: Mac OS X .dylib not working Date: Fri, 04 Mar 2011 13:00:20 -0600 Message-ID: <4D7136C4.7030600@pogma.com> References: <4D705581.1030701@pogma.com> <24B671DD-89B7-4FBC-BDC5-39E6C058872E@telia.com> <4D712A62.2090901@pogma.com> <20110304184724.GL10500@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1299265241 27743 80.91.229.12 (4 Mar 2011 19:00:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 4 Mar 2011 19:00:41 +0000 (UTC) To: Hans Aberg , Guile bug , =?ISO-8859-1?Q?Ludovic_Court=E8s?= , Michael Ellis , libtool-patches@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Mar 04 20:00:36 2011 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PvaEs-0003q1-Rr for guile-bugs@m.gmane.org; Fri, 04 Mar 2011 20:00:35 +0100 Original-Received: from localhost ([127.0.0.1]:41234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PvaEs-0002N0-Bo for guile-bugs@m.gmane.org; Fri, 04 Mar 2011 14:00:34 -0500 Original-Received: from [140.186.70.92] (port=50073 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PvaEi-0002MK-Is for bug-guile@gnu.org; Fri, 04 Mar 2011 14:00:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PvaEh-0005EB-CU for bug-guile@gnu.org; Fri, 04 Mar 2011 14:00:24 -0500 Original-Received: from pogma.xen.prgmr.com ([68.68.97.8]:50830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvaEh-0005E2-3Y; Fri, 04 Mar 2011 14:00:23 -0500 Original-Received: from tw.local (wnpgmb1316w-ds01-50-57.dynamic.mtsallstream.net [206.45.50.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pogma.xen.prgmr.com (Postfix) with ESMTP id 648CEBF5DB; Fri, 4 Mar 2011 19:00:30 +0000 (UTC) X-DKIM: Sendmail DKIM Filter v2.8.3 pogma.xen.prgmr.com 648CEBF5DB DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pogma.com; s=pogmail; t=1299265230; bh=JVtJAzpHIs+qxu2uKMM78ovu27bJ2LaMsE2J8GHG6X8=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=g0hRniaXxr3ArqY8kCO+n2gMFXBduEjglSVKMdBBMiTm1YDm9ktV39sFP/eijawqp yLMvkq6FhSSPMOTr2eIpN6rqLw1rDHyaaL0CPvbi55FmU7l3QJMKyXFAHUL4QClNP/ LjeZPDocCawDQ+HpMk994QozoXASN+xT6wmH465Q= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Thunderbird/3.1.7 In-Reply-To: <20110304184724.GL10500@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 68.68.97.8 X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:5285 gmane.comp.gnu.libtool.patches:11062 Archived-At: On 03/04/2011 12:47 PM, Ralf Wildenhues wrote: > [ dropping bug-libtool ] > > Hi Peter, > > * Peter O'Gorman wrote on Fri, Mar 04, 2011 at 07:07:30PM CET: >> Ok? > > A few copyright year bumps are missing. Oh, yeah, will fix. > Some minor nits inline below. >> +AT_SETUP(darwin can lt_dlopen .dylib and .so files) > > Missing m4 quotes (for style only) Ok. >> +AT_CHECK([test "$shared_ext" != "$module_ext" || exit 77], >> + [], [ignore]) > > You can drop arguments two and three here. Ok. >> + int errors = 0; > > Isn't this lacking > LTDL_SET_PRELOADED_SYMBOLS(); > > or was that needed only for static libs (which you've excluded earlier)? It's only needed for static. This bit was copy&pasted from lt_dlopenext.at. >> + if (lt_dlexit () != 0) >> + errormsg = dlerrordup (errormsg); > > I'm not particularly fond of this coding style, where ownership > information essentially gets lots once an error occurs in any > of the commands. Might be ok for a test like this, but not such > a good example for users. lt_dlexit could be warranted even if > some error occurred before. Anyway, I won't reject the patch for > this. Ok, to be honest I didn't even read much of this code, it's from lt_dlopenext.at. > >> +if test "$shlibpath_var" = PATH; then > > This looks wrong; shouldn't it be != here? Otherwise, ... Again, didn't read it!! Will look into it and fix the old test if it's wrong. This bit is not needed or used in the new test anyway, will remove it. Thanks for the quick review. I will adjust and push, probably tomorrow. Peter