From: Peter O'Gorman <peter@pogma.com>
To: "Hans Aberg" <haberg-1@telia.com>,
"Guile bug" <bug-guile@gnu.org>, "Ludovic Courtès" <ludo@gnu.org>,
"Michael Ellis" <michael.f.ellis@gmail.com>,
libtool-patches@gnu.org
Subject: Re: Mac OS X .dylib not working
Date: Fri, 04 Mar 2011 13:00:20 -0600 [thread overview]
Message-ID: <4D7136C4.7030600@pogma.com> (raw)
In-Reply-To: <20110304184724.GL10500@gmx.de>
On 03/04/2011 12:47 PM, Ralf Wildenhues wrote:
> [ dropping bug-libtool ]
>
> Hi Peter,
>
> * Peter O'Gorman wrote on Fri, Mar 04, 2011 at 07:07:30PM CET:
>> Ok?
>
> A few copyright year bumps are missing.
Oh, yeah, will fix.
> Some minor nits inline below.
>> +AT_SETUP(darwin can lt_dlopen .dylib and .so files)
>
> Missing m4 quotes (for style only)
Ok.
>> +AT_CHECK([test "$shared_ext" != "$module_ext" || exit 77],
>> + [], [ignore])
>
> You can drop arguments two and three here.
Ok.
>> + int errors = 0;
>
> Isn't this lacking
> LTDL_SET_PRELOADED_SYMBOLS();
>
> or was that needed only for static libs (which you've excluded earlier)?
It's only needed for static. This bit was copy&pasted from lt_dlopenext.at.
>> + if (lt_dlexit () != 0)
>> + errormsg = dlerrordup (errormsg);
>
> I'm not particularly fond of this coding style, where ownership
> information essentially gets lots once an error occurs in any
> of the commands. Might be ok for a test like this, but not such
> a good example for users. lt_dlexit could be warranted even if
> some error occurred before. Anyway, I won't reject the patch for
> this.
Ok, to be honest I didn't even read much of this code, it's from
lt_dlopenext.at.
>
>> +if test "$shlibpath_var" = PATH; then
>
> This looks wrong; shouldn't it be != here? Otherwise, ...
Again, didn't read it!! Will look into it and fix the old test if it's
wrong.
This bit is not needed or used in the new test anyway, will remove it.
Thanks for the quick review. I will adjust and push, probably tomorrow.
Peter
next prev parent reply other threads:[~2011-03-04 19:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 19:32 Mac OS X .dylib not working Hans Åberg
2011-03-03 19:56 ` Michael Ellis
2011-03-04 2:59 ` Peter O'Gorman
2011-03-04 3:41 ` Michael Ellis
2011-03-04 8:59 ` Andy Wingo
2011-03-04 9:44 ` Hans Aberg
2011-03-04 18:07 ` Peter O'Gorman
2011-03-04 18:47 ` Ralf Wildenhues
2011-03-04 19:00 ` Peter O'Gorman [this message]
2011-03-05 16:16 ` Peter O'Gorman
2011-03-04 3:00 ` Bob Friesenhahn
2011-03-04 3:48 ` Michael Ellis
2011-03-04 17:04 ` Ralf Wildenhues
2011-03-04 9:47 ` Hans Aberg
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 19:53 Hans Aberg
2010-02-01 14:26 Hans Aberg
2010-02-02 6:42 ` Ralf Wildenhues
2010-02-02 9:08 ` Hans Aberg
2010-02-02 14:20 ` Ken Raeburn
2010-02-02 15:48 ` Hans Aberg
2010-02-02 16:52 ` Bob Friesenhahn
2010-02-02 17:15 ` Hans Aberg
2010-02-02 18:01 ` Ludovic Courtès
2010-02-03 14:23 ` Ken Raeburn
2010-02-03 15:10 ` Ludovic Courtès
2010-02-04 12:40 ` Hans Aberg
2010-02-04 13:49 ` Peter O'Gorman
2010-02-04 15:21 ` Hans Aberg
2010-02-04 15:34 ` Peter O'Gorman
2010-02-04 16:52 ` Hans Aberg
2010-02-04 16:58 ` Hans Aberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7136C4.7030600@pogma.com \
--to=peter@pogma.com \
--cc=bug-guile@gnu.org \
--cc=haberg-1@telia.com \
--cc=libtool-patches@gnu.org \
--cc=ludo@gnu.org \
--cc=michael.f.ellis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).