unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: "Neil Jerram" <neiljerram@googlemail.com>
To: linasvepstas@gmail.com
Cc: bug-guile@gnu.org
Subject: Re: [PATCH] Final: thread lock nesting debugging
Date: Wed, 19 Nov 2008 23:21:53 +0000	[thread overview]
Message-ID: <49dd78620811191521vdc920cenacc5c4d4040a37a1@mail.gmail.com> (raw)
In-Reply-To: <49dd78620811191514m6e73438esd4f1474c9926880d@mail.gmail.com>

2008/11/19 Neil Jerram <neiljerram@googlemail.com>:
> 2008/11/17 Linas Vepstas <linasvepstas@gmail.com>:
>> I've been seeing all sorts of deadlocks in guile, and so I wrote a small
>> debugging utility to try to track down the problems.
>
> Interesting patch!
>
> One query; I may be being a bit dumb, I'm only just recovering from a
> bad cold, but anyway...  Your patch checks for a thread unlocking
> mutexes in the reverse order that it locked them in (let's call this
> point "A").  But I thought your recent investigations had shown that
> the problem was threads doing locking in inconsistent order, e.g.
> thread 1 locks M1 and then M2, while thread 2 locks M2 and then M1
> (point "B").  Are points "A" and "B" equivalent?  (It isn't obvious to
> me if so.)

Also I wondered if there are already tools to debug this kind of thing
(without new Guile code), and a quick search finds this [1], which
suggests that helgrind could catch bad lock ordering for us.

[1] http://www.network-theory.co.uk/docs/valgrind/valgrind_113.html

      Neil




  reply	other threads:[~2008-11-19 23:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  4:42 [PATCH] Final: thread lock nesting debugging Linas Vepstas
2008-11-17 13:21 ` Han-Wen Nienhuys
2008-11-18 13:26 ` Ludovic Courtès
2008-11-19 23:14 ` Neil Jerram
2008-11-19 23:21   ` Neil Jerram [this message]
2008-11-20  0:22     ` Neil Jerram
2008-11-20 16:03   ` Linas Vepstas
2008-11-20 18:33     ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49dd78620811191521vdc920cenacc5c4d4040a37a1@mail.gmail.com \
    --to=neiljerram@googlemail.com \
    --cc=bug-guile@gnu.org \
    --cc=linasvepstas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).