From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Marijn Schouten (hkBst)" Newsgroups: gmane.lisp.guile.bugs Subject: Re: sleep 999 after tests Date: Fri, 17 Aug 2007 10:12:09 +0200 Message-ID: <46C55859.5020108@gentoo.org> References: <4656F9EA.4090300@phys.uu.nl> <87k5rvgjna.fsf@zip.com.au> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1187338385 24823 80.91.229.12 (17 Aug 2007 08:13:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2007 08:13:05 +0000 (UTC) Cc: bug-guile@gnu.org To: Kevin Ryde Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Aug 17 10:13:02 2007 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ILwx3-0002WP-Jo for guile-bugs@m.gmane.org; Fri, 17 Aug 2007 10:13:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILwx2-0002AB-Kl for guile-bugs@m.gmane.org; Fri, 17 Aug 2007 04:13:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ILwwz-0002A4-Pi for bug-guile@gnu.org; Fri, 17 Aug 2007 04:12:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ILwwx-00029j-VI for bug-guile@gnu.org; Fri, 17 Aug 2007 04:12:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILwwx-00029c-Q3 for bug-guile@gnu.org; Fri, 17 Aug 2007 04:12:55 -0400 Original-Received: from castor.sshunet.nl ([145.97.192.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ILwwx-0007st-Ei for bug-guile@gnu.org; Fri, 17 Aug 2007 04:12:55 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by castor.sshunet.nl (Postfix) with ESMTP id 67F3957C005; Fri, 17 Aug 2007 10:12:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at castor.sshunet.nl Original-Received: from castor.sshunet.nl ([127.0.0.1]) by localhost (castor.sshunet.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OohqIV3PVudM; Fri, 17 Aug 2007 10:12:54 +0200 (CEST) Original-Received: from [145.97.222.61] (61pc222.sshunet.nl [145.97.222.61]) by castor.sshunet.nl (Postfix) with ESMTP; Fri, 17 Aug 2007 10:12:54 +0200 (CEST) User-Agent: Thunderbird 2.0.0.6 (X11/20070802) In-Reply-To: <87k5rvgjna.fsf@zip.com.au> X-Enigmail-Version: 0.95.3 X-Detected-Kernel: Linux 2.6 (newer, 3) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:3566 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kevin Ryde wrote: > [belated followup] > > Marijn Schouten writes: >> the two sleep 999's in test-suite/tests/popen.test are really annoying. Is >> there any good reason for them to be there? > > Yep. The parent process is supposed to see eof from the child, and in > normal operation it then continues. If it blocks for the whole sleep > 999 then something has gone wrong. > >> - "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null; >> sleep 999"))))) >> + "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null; >> sleep 1"))))) > > Alas, no, 1 second may not be long enough for the parent to notice what > the child has done, depending on system load etc. > > (It may be possible to make a better test, but bear in mind there was an > actual bug in that area in the past, which the tests are trying to > ensure doesn't raise its ugly head again.) This test depends on networking being enabled. If networking is disabled it should preferably not run at all, but if it runs it should fail in an acceptable amount of time. So how about making it 30 seconds? - -- Marijn Schouten (hkBst), Gentoo Lisp project , #gentoo-lisp -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGxVhZp/VmCx0OL2wRApccAJ47fObzedfgMgpRyTmboWtt2oWvLQCeL3QZ YJNKo1E0lcjbuRXxCE16RqU= =BLHM -----END PGP SIGNATURE----- _______________________________________________ Bug-guile mailing list Bug-guile@gnu.org http://lists.gnu.org/mailman/listinfo/bug-guile