From: "Marijn Schouten (hkBst)" <hkBst@gentoo.org>
To: Kevin Ryde <user42@zip.com.au>
Cc: bug-guile@gnu.org
Subject: Re: sleep 999 after tests
Date: Fri, 17 Aug 2007 10:12:09 +0200 [thread overview]
Message-ID: <46C55859.5020108@gentoo.org> (raw)
In-Reply-To: <87k5rvgjna.fsf@zip.com.au>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kevin Ryde wrote:
> [belated followup]
>
> Marijn Schouten <M.Schouten@phys.uu.nl> writes:
>> the two sleep 999's in test-suite/tests/popen.test are really annoying. Is
>> there any good reason for them to be there?
>
> Yep. The parent process is supposed to see eof from the child, and in
> normal operation it then continues. If it blocks for the whole sleep
> 999 then something has gone wrong.
>
>> - "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null;
>> sleep 999")))))
>> + "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null;
>> sleep 1")))))
>
> Alas, no, 1 second may not be long enough for the parent to notice what
> the child has done, depending on system load etc.
>
> (It may be possible to make a better test, but bear in mind there was an
> actual bug in that area in the past, which the tests are trying to
> ensure doesn't raise its ugly head again.)
This test depends on networking being enabled. If networking is disabled it
should preferably not run at all, but if it runs it should fail in an
acceptable amount of time. So how about making it 30 seconds?
- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGxVhZp/VmCx0OL2wRApccAJ47fObzedfgMgpRyTmboWtt2oWvLQCeL3QZ
YJNKo1E0lcjbuRXxCE16RqU=
=BLHM
-----END PGP SIGNATURE-----
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile
next prev parent reply other threads:[~2007-08-17 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 14:59 sleep 999 after tests Marijn Schouten
2007-08-16 23:11 ` Kevin Ryde
2007-08-17 8:12 ` Marijn Schouten (hkBst) [this message]
2007-08-17 13:19 ` Ludovic Courtès
2007-08-17 13:25 ` Marijn Schouten (hkBst)
2007-08-19 0:50 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C55859.5020108@gentoo.org \
--to=hkbst@gentoo.org \
--cc=bug-guile@gnu.org \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).