unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* guile-www-2.9 (www cgi) names in query-string not url-decoded
@ 2005-04-11 23:10 Alan Grover
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Grover @ 2005-04-11 23:10 UTC (permalink / raw)


The (www cgi) module parses query-string/form-data without performing an 
url-decode on names. Values are url-decoded.

Module: www cgi
Version: 2.9

Example:
	http://gnu.org?with%26amper=
should parse to ("with&amper" . '()). But, incorrectly parses to 
("with%26amper" . '()).


Suggested patch:

cgi.scm

286c286
<       (and p (subs pair 0 p))))
---
 >       (and p (url-coding:decode (subs pair 0 p)))))

-- 
Alan Grover
awgrover@mail.msen.com
+1.734.476.0969


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: guile-www-2.9 (www cgi) names in query-string not url-decoded
@ 2005-04-12  0:40 Thien-Thi Nguyen
  0 siblings, 0 replies; 2+ messages in thread
From: Thien-Thi Nguyen @ 2005-04-12  0:40 UTC (permalink / raw)
  Cc: bug-guile

   From: Alan Grover <awgrover@mail.msen.com>
   Date: Mon, 11 Apr 2005 19:10:24 -0400

   cgi.scm

   286c286
   <       (and p (subs pair 0 p))))
   ---
    >       (and p (url-coding:decode (subs pair 0 p)))))

thanks, installed.

here is the ChangeLog entry i used:

2005-04-12  Alan Grover  <awgrover@mail.msen.com>  (tiny change)

	* cgi.scm (parse-form): Fix omission bug:
	Also url-decode name in each name/value pair.

feel free to include something along these lines for future patches.
(also, i find "diff -u" output easier to evaluate.)

thi


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-04-12  0:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-11 23:10 guile-www-2.9 (www cgi) names in query-string not url-decoded Alan Grover
  -- strict thread matches above, loose matches on Subject: below --
2005-04-12  0:40 Thien-Thi Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).