From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Taylan Kammer Newsgroups: gmane.lisp.guile.bugs Subject: bug#72367: srfi-64: nested group not counted as one test Date: Mon, 30 Sep 2024 16:42:34 +0200 Message-ID: <36bb1a5e-b212-4a1d-88dc-c88e16a47182@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Tomas Volf <~@wolfsden.cz>, 72367@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Mon Sep 30 16:46:05 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svHf2-0005f4-Pq for guile-bugs@m.gmane-mx.org; Mon, 30 Sep 2024 16:46:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svHef-0001ov-EZ; Mon, 30 Sep 2024 10:45:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svHeW-0001oA-Vy for bug-guile@gnu.org; Mon, 30 Sep 2024 10:45:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svHeW-0001WE-Lx for bug-guile@gnu.org; Mon, 30 Sep 2024 10:45:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=f8byBoMi54Mbtp1CSUtActBzBTkUZ8koWosL4l3Me84=; b=NqofefpYf3hO7DDKg/R6Zxvr0RlJbVcXvk0ryn5v6i62RMPn9QZIxZea6dLGsOmDr5f/FQbi+kJ3G00PPIkrFKF7vilAuARoAp39YErdzJ8cMqgxevqIsD6qbhE7mJ17REs40KkuMi6cqSWVgxZa9cUTfVg0RJ9rbiVlZ0jKiAng8iZtV/9GFT5pC2t7vnoNxvQzOxxWmIm47/s+FDUlCSmnmYWBZkb1+Po4eUkxLzaZr5zv48H/B1GAI/CXcvHDV9KY/oLvJKP5V9TgR/W7IGJV+zpxZBpJ1dc9l53KR8qOoJlv39M0KnqnJpaRWtq8QeAKfPR3WlO4RZBNO+fkrg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svHf2-0001jD-CQ for bug-guile@gnu.org; Mon, 30 Sep 2024 10:46:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Taylan Kammer Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 30 Sep 2024 14:46:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72367 X-GNU-PR-Package: guile Original-Received: via spool by 72367-submit@debbugs.gnu.org id=B72367.17277075135824 (code B ref 72367); Mon, 30 Sep 2024 14:46:04 +0000 Original-Received: (at 72367) by debbugs.gnu.org; 30 Sep 2024 14:45:13 +0000 Original-Received: from localhost ([127.0.0.1]:45259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svHe8-0001V8-Bs for submit@debbugs.gnu.org; Mon, 30 Sep 2024 10:45:11 -0400 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:41697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svHdG-0001J8-Ud for 72367@debbugs.gnu.org; Mon, 30 Sep 2024 10:44:38 -0400 Original-Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a8a913874b8so48729366b.2 for <72367@debbugs.gnu.org>; Mon, 30 Sep 2024 07:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727707356; x=1728312156; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=f8byBoMi54Mbtp1CSUtActBzBTkUZ8koWosL4l3Me84=; b=A0k1YfkK8QoUGYeEmhb9shMCwqQpy/8/xgQgpLCbLoAMN4a8AD/IO7+nmP3czvskN8 0SEVrpJ9DU63/dhWehOdOclnIMPIEwemz6m3WNjhLXyiMc5243/dC75aXHY7aI3L9g9m 5bWJv8QBRAYiY0VKSY2T+9v6OO7AT8OgLxfSEIcU6m8SxN+isduBtt+DFtYzgGRJ1SDH TgEw8A0ksznPpVNXy0ocydz/tGxupVq12R3D+cstDFXwqS1IT1ho/ygfxSbQ/zEiW5CX 8TxCv9pKSctIMXEm+JJnz5U+pTpkyzX/K70I8gPCtWfrhXZH6LWHIrrRTz/2PPze5/EP UrrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727707356; x=1728312156; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f8byBoMi54Mbtp1CSUtActBzBTkUZ8koWosL4l3Me84=; b=PGcsuEp8hs9nm7Niv4nXxMYYhRmrcWbvjDbOCF0l46Nz6xWtzWJELVnO6OYkHOzJRm cUtG0l1UlLnsW3IpwWjKtYWlbiBy1vbmNL+Ef4C+HUwr5lLKzcCWG8Z4JyFXrTS+kXI6 bOpV4ALarx4nOJ2qruiajgOl1PqeCK3jQYbO5lBTUPeYWDJJFGBKPOIlKcE9XQbzt+N/ 9N0VbP+CC4tZAkeKrH5oGQn7/sMGxEBX6lFG26p/PuAmQyrgBXEa/3m3RUKba2vTUd4N yzveTlvxDTjAYxbDS27MlCkDxymgzdAxT5iF9UjUeq6rq6eK2xn2Ngrx1uI0QCZ/y2/L zU7A== X-Forwarded-Encrypted: i=1; AJvYcCU5sHGqAMZhiuEcHY/DrWO6EmadCmU0XYGUeYM24oC2S0HybSKJOJ3x8ZEMIdAOsUAWHNi2SA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy6fQtjyzg2QJu6ItkMAFeAUrEBZSf+b/EIj2JO87iGSBmh++Uf k1S4zh4gyijYT7qM6kAfhWGnoxVxKfh4iUGKHqbDUeieY6jbj/9Ihfm9QLhd X-Google-Smtp-Source: AGHT+IHVDPfybYuMPCPz/jooKQnILS/312kOFboHpAZyLDzdXBIra173IH1LXCg6EEOyBCamOAubQg== X-Received: by 2002:a17:907:9721:b0:a80:ed7e:8468 with SMTP id a640c23a62f3a-a93d84d4462mr471910966b.0.1727707355771; Mon, 30 Sep 2024 07:42:35 -0700 (PDT) Original-Received: from ?IPV6:2003:106:8f04:c300:192e:476d:8ae3:22f2? (p200301068f04c300192e476d8ae322f2.dip0.t-ipconnect.de. [2003:106:8f04:c300:192e:476d:8ae3:22f2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c2946f78sm539871066b.110.2024.09.30.07.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 07:42:35 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10996 Archived-At: On 30.07.2024 21:51, Tomas Volf wrote: > Hello, > > I think I found a bug in (srfi srfi-64) module shipped with GNU Guile. > > The specification says the following about the count argument to the test-begin > form: > >> The optional count must match the number of test-cases executed by this >> group. (Nested test groups count as a single test case for this count.) > Thus I believe that following should *not* call on-bad-count-function. > > (use-modules (srfi srfi-64)) > (let ((r (test-runner-null))) > (test-runner-current r) > (test-runner-on-bad-count! r (λ (runner actual-count expected-count) > (pk (test-runner-group-stack runner)) > (pk actual-count expected-count))) > (test-begin "x" 1) > (test-begin "y" 3) > (test-assert #t) > (test-assert #t) > (test-assert #t) > (test-end) > (test-end)) > > However as we can see it does: > > ;;; (("x")) > > ;;; (3 1) > > Have a nice day > Tomas Volf Looks like a bug indeed. I believe I was able to fix it in my implementation with this commit:     https://codeberg.org/taylan/scheme-srfis/commit/c49e367fbf292c6ee66ff435c7daa1f4ae5a47fa An equivalent fix could be applied to the upstream reference implementation / current Guile implementation. - Taylan