From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Bruno Haible Newsgroups: gmane.lisp.guile.bugs Subject: bug#36342: accept4 detection on illumos needs -lsocket -lnsl Date: Sat, 29 Jun 2019 02:06:05 +0200 Message-ID: <3505782.aKLV2fzV26__16337.7477599838$1561766835$gmane$org@omega> References: <2f3c5921-d3e9-4c06-4a21-826d7ba58bcf@startmail.com> <87sgrtfied.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236844"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: KMail/5.1.3 (Linux/4.4.0-151-generic; KDE/5.18.0; x86_64; ; ) Cc: Michal Nowak , 36342@debbugs.gnu.org To: bug-gnulib@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sat Jun 29 02:07:10 2019 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hh0tZ-000zTk-Oe for guile-bugs@m.gmane.org; Sat, 29 Jun 2019 02:07:09 +0200 Original-Received: from localhost ([::1]:37096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh0tY-0008G8-QK for guile-bugs@m.gmane.org; Fri, 28 Jun 2019 20:07:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59643) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh0tU-0008Fp-F5 for bug-guile@gnu.org; Fri, 28 Jun 2019 20:07:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hh0tS-0000mj-SC for bug-guile@gnu.org; Fri, 28 Jun 2019 20:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hh0tS-0000mY-OR for bug-guile@gnu.org; Fri, 28 Jun 2019 20:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hh0tS-0000VC-Ew for bug-guile@gnu.org; Fri, 28 Jun 2019 20:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bruno Haible Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 29 Jun 2019 00:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36342 X-GNU-PR-Package: guile Original-Received: via spool by 36342-submit@debbugs.gnu.org id=B36342.15617667801840 (code B ref 36342); Sat, 29 Jun 2019 00:07:02 +0000 Original-Received: (at 36342) by debbugs.gnu.org; 29 Jun 2019 00:06:20 +0000 Original-Received: from localhost ([127.0.0.1]:43187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh0sh-0000TR-4j for submit@debbugs.gnu.org; Fri, 28 Jun 2019 20:06:19 -0400 Original-Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.166]:35035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh0se-0000TF-3a for 36342@debbugs.gnu.org; Fri, 28 Jun 2019 20:06:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1561766770; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=M5zOMF/X/aI3ThABGBwiXhA8mmegZnqdB2E/9UcWT40=; b=q/OcWYgeJV8eZ00ZYcXkIiCR5DJCsEJZ+ElXO6HIyWFF3DMcxBL+K5fv2pE0SSWLzG S/MymoarDuaoH/UKZmqWG1V2fuSGFQGhjiBGU+Zcjy432O284MYRvhFJxRCvQGUUqxKn wUqHZrzFY7vIQZXcifdIaZWC+puxUA5UFkpJrm8eitj/Bku9anBX0FAMrV8vaisAIQ4c p3XkCAHDi04LhDZOXNfgR6HUgDmfjRZhrBPcMinXcFvlpermHj5UGU4n2yIqLPjssHSH US9EEZ6PUjH1hwMJckSnaOTtxwL33eHZHisUyfQYExAK0t8ArP+zG29JPJgvxEwz9CKr spcw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGaf0zJZW" X-RZG-CLASS-ID: mo00 Original-Received: from bruno.haible.de by smtp.strato.de (RZmta 44.24 DYNA|AUTH) with ESMTPSA id v018bcv5T066kYx (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sat, 29 Jun 2019 02:06:06 +0200 (CEST) In-Reply-To: <87sgrtfied.fsf@netris.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9374 Archived-At: Hi Michal and Mark, > > GNU Guile 2.2.5 build fails because accept4 detection on OpenIndiana > > 2019.04 (illumos distribution) [1] fails due to "-lsocket -lnsl" not > > being part of the linking process and the build system then tries to > > build it's vendored accept4: > > I believe this is an issue in gnulib, because the relevant autoconf > detection code, as well as the replacement implementation that fails to > compile on OpenIndiana, are imported from gnulib. > > I've CC'd the bug-gnulib@gnu.org mailing list, for input from the gnulib > developers. > > Thanks for this report, > > Mark > > > > CC accept4.lo > > In file included from /usr/include/sys/time.h:462:0, > > from ./sys/time.h:39, > > from /usr/include/sys/select.h:53, > > from ./sys/select.h:36, > > from /usr/include/sys/types.h:640, > > from ./sys/types.h:28, > > from ./sys/socket.h:51, > > from accept4.c:20: > > ./sys/socket.h:1034:1: error: conflicting types for 'accept4' > > _GL_FUNCDECL_SYS (accept4, int, > > ^ > > In file included from ./sys/socket.h:58:0, > > from accept4.c:20: > > /usr/include/sys/socket.h:540:12: note: previous declaration of > > 'accept4' was here > > extern int accept4(int, struct sockaddr *_RESTRICT_KYWD, Psocklen_t, > > int); > > ^~~~~~~ > > accept4.c:32:1: error: conflicting types for 'accept4' > > accept4 (int sockfd, struct sockaddr *addr, socklen_t *addrlen, int > > flags) > > ^~~~~~~ > > In file included from ./sys/socket.h:58:0, > > from accept4.c:20: > > /usr/include/sys/socket.h:540:12: note: previous declaration of > > 'accept4' was here > > extern int accept4(int, struct sockaddr *_RESTRICT_KYWD, Psocklen_t, > > int); > > ^~~~~~~ > > > > This is fixed by LIBS="-lsocket -lnsl" in the build environment. > > > > This was in the past reported both on the guile-user [2] and > > openindiana-discuss [3] mailing lists, where you also can see the > > build error in full. > > > > Thanks, > > Michal > > > > [1] https://illumos.org/man/3socket/accept4 > > [2] https://lists.gnu.org/archive/html/guile-user/2018-03/msg00006.html > > [3] > > https://openindiana.org/pipermail/openindiana-discuss/2018-March/021931.html Thanks for the report. This patch fixes it. Pushed. Now, guile needs to pick it up. 2019-06-28 Bruno Haible accept4: Fix compilation error on OpenIndiana. Reported by Michal Nowak via Mark H Weaver . * m4/accept.m4 (gl_FUNC_ACCEPT4): Test whether accept4 is declared, not whether it exists as a function. diff --git a/m4/accept4.m4 b/m4/accept4.m4 index b38ce30..9b976fb 100644 --- a/m4/accept4.m4 +++ b/m4/accept4.m4 @@ -1,4 +1,4 @@ -# accept4.m4 serial 2 +# accept4.m4 serial 3 dnl Copyright (C) 2009-2019 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -11,8 +11,11 @@ AC_DEFUN([gl_FUNC_ACCEPT4], dnl Persuade glibc to declare accept4(). AC_REQUIRE([AC_USE_SYSTEM_EXTENSIONS]) - AC_CHECK_FUNCS_ONCE([accept4]) - if test $ac_cv_func_accept4 != yes; then + AC_CHECK_DECLS([accept4], , , [[ +#include +#include +]]) + if test $ac_cv_have_decl_accept4 != yes; then HAVE_ACCEPT4=0 fi ])