From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.lisp.guile.bugs Subject: bug#61095: possible misuse of posix_spawn API on non-linux OSes Date: Fri, 31 Mar 2023 19:45:55 +0200 Message-ID: <2KFIQJHFVA0GP.2GKMWUIGIVCMU@venera> References: <26OIN3L5D4V9L.2M0KM95K0YSNM@venera> <87zg7xgqxz.fsf@gnu.org> <87tty4svpo.fsf@jpoiret.xyz> <87zg7vjimr.fsf@inria.fr> <87ileirnw7.fsf@jpoiret.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14282"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mblaze/1.2 Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Andrew Whatson , 61095@debbugs.gnu.org To: Josselin Poiret Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Fri Mar 31 19:47:28 2023 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piIqV-0003Qa-AB for guile-bugs@m.gmane-mx.org; Fri, 31 Mar 2023 19:47:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piIq8-0003xX-DH; Fri, 31 Mar 2023 13:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piIq6-0003x8-N3 for bug-guile@gnu.org; Fri, 31 Mar 2023 13:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piIq6-0005Wf-7a for bug-guile@gnu.org; Fri, 31 Mar 2023 13:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piIq5-0002oF-JK for bug-guile@gnu.org; Fri, 31 Mar 2023 13:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Omar Polo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 31 Mar 2023 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61095 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 61095-submit@debbugs.gnu.org id=B61095.168028476510728 (code B ref 61095); Fri, 31 Mar 2023 17:47:01 +0000 Original-Received: (at 61095) by debbugs.gnu.org; 31 Mar 2023 17:46:05 +0000 Original-Received: from localhost ([127.0.0.1]:34435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piIpB-0002my-D8 for submit@debbugs.gnu.org; Fri, 31 Mar 2023 13:46:05 -0400 Original-Received: from mail.omarpolo.com ([144.91.116.244]:65267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piIp9-0002mK-G6 for 61095@debbugs.gnu.org; Fri, 31 Mar 2023 13:46:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1680284756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gX0Qww+3KoTbXkWrUbtSd3lcncwlDY3TMRefTYiD8Fc=; b=XohcRwUgXdNHu4n+2v3TpotEa/iyesyvl6hNvHHeyM44ijE/4lYKBoJ8wEqa+5AR0Og9fF gooCCaTCo7/ZyABqPjDWApQ3PMVzykFqUpnAqhccd613Aw65e5J3p0UTRB3aWgAU2V5E0W pL1US4phsqXNCy27CNufa0sjjmP5x2g= Original-Received: from localhost (host-82-61-20-205.retail.telecomitalia.it [82.61.20.205]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 9f3f726d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 31 Mar 2023 19:45:56 +0200 (CEST) Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ce8644ed; Fri, 31 Mar 2023 19:45:55 +0200 (CEST) In-Reply-To: <87ileirnw7.fsf@jpoiret.xyz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10590 Archived-At: On 2023/03/30 22:21:28 +0200, Josselin Poiret wrote: > Hi Ludo, >=20 > Ludovic Court=C3=A8s writes: >=20 > > Coming next is an updated patch series addressing this as proposed > > above. Let me know what y=E2=80=99all think! > > > > I tested the =E2=80=98posix_spawn_file_actions_addclosefrom_np=E2=80=99= path by building in: > > > > guix time-machine --branch=3Dcore-updates -- shell -CP -D -f guix.scm= >=20 > I didn't test, but this LGTM! Maybe someone on OpenBSD could test this > patchset? % gmake check gmake[5]: Entering directory '/home/op/w/guile/test-suite/standalone' PASS: test-system-cmds it seems to work on OpenBSD 7.3 :) but note that our libc doesn't have posix_spawn_file_actions_addclosefrom_n= p, so this is using the "racy" code path. Just for curiosity, as it's outside the scope of the bug, what's the reason posix_spawn was used instead of a more classic fork() + closefrom()? Thanks, Omar Polo