unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Yan Li <yan.i.li@intel.com>
To: bug-guile@gnu.org
Cc: yanli@gnome.org
Subject: [PATCH] Compiling DOT_X_FILES requires version.h
Date: Wed, 4 Aug 2010 15:02:43 +0800	[thread overview]
Message-ID: <26f7d03710529a3bae3a2b6b7417bd4348e908f8.1280904428.git.yan.i.li@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

There was a race condition when building Guile since DOT_X_FILES didn't
depend on version.h, which is dynamically generated. Sometimes the
DOT_X_FILES are compiled before the version.h is generated and leads to
build failure. This patch fixed this problem.

Signed-off-by: Yan Li <yan.i.li@intel.com>
---
 libguile/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libguile/Makefile.am b/libguile/Makefile.am
index a899b85..9836aa1 100644
--- a/libguile/Makefile.am
+++ b/libguile/Makefile.am
@@ -670,7 +670,7 @@ AM_V_FILTER_0 = @echo "  FILTER" $@;
 .c.doc:
 	-$(AM_V_FILTER)$(AWK) -f $(srcdir)/guile-func-name-check $< && (./guile-snarf-docs $(snarfcppopts) $< | ./guile_filter_doc_snarfage$(EXEEXT) --filter-snarfage) > $@ || { rm $@; false; }
 
-$(DOT_X_FILES) $(EXTRA_DOT_X_FILES): scmconfig.h snarf.h guile-snarf.in
+$(DOT_X_FILES) $(EXTRA_DOT_X_FILES): scmconfig.h snarf.h guile-snarf.in version.h
 
 $(DOT_DOC_FILES) $(EXTRA_DOT_DOC_FILES): scmconfig.h snarf.h guile-snarf-docs.in guile_filter_doc_snarfage$(EXEEXT)
 
-- 
1.7.1


-- 
Best regards,
Li, Yan

MeeGo Team, Opensource Technology Center, SSG, Intel
Office tel.: +86-10-82171695 (inet: 8-758-1695)
OpenPGP key: 5C6C31EF
IRC: yanli on network irc.freenode.net

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2010-08-04  7:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04  7:02 Yan Li [this message]
2010-08-04 18:21 ` [PATCH] Compiling DOT_X_FILES requires version.h Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26f7d03710529a3bae3a2b6b7417bd4348e908f8.1280904428.git.yan.i.li@intel.com \
    --to=yan.i.li@intel.com \
    --cc=bug-guile@gnu.org \
    --cc=yanli@gnome.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).