From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Taylan Kammer Newsgroups: gmane.lisp.guile.bugs Subject: bug#72366: srfi-64: on-bad-end-name-function has swapped arguments Date: Wed, 2 Oct 2024 01:47:05 +0200 Message-ID: <218f9d93-6ba5-437c-b6ac-71207985f537@gmail.com> References: <6e4c71b8-e46a-4358-8daf-2f6e1d9de1b5@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------PiXVo7A2go6KMr0sYeVxfDEE" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20714"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Tomas Volf <~@wolfsden.cz>, 72366@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Wed Oct 02 01:49:28 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svmcR-0005Dp-DO for guile-bugs@m.gmane-mx.org; Wed, 02 Oct 2024 01:49:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svmc5-0007AK-F8; Tue, 01 Oct 2024 19:49:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svmc2-00079r-It for bug-guile@gnu.org; Tue, 01 Oct 2024 19:49:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svmc2-0003Cu-95 for bug-guile@gnu.org; Tue, 01 Oct 2024 19:49:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:From:MIME-Version:Date:To:Subject; bh=q+vu0zKnS/O/kPe87Y/hgimdt8bkmew2K55hnRpsGHA=; b=uQ6BknqScrtPN4WrmD7eLKyb1ZW3bv0oh6oUBzhE4rE5cvbz5xsAKFmGDLkNI5Yb+d5+sQSvoD/6T44H5Si2OXhQ37v9c6Icaf42dR97cKZOCUH3W6SVXwt5qaOKBhRwIZQgIGR7lvDr9GqkYN5VHc6GxmhcuFOydA2ZDjdf4N9xYTt7ldLHR8ZZsZUosGOMhEECGt0HeeY7C3A/sqoyJyflSiKJHhX8iaBTcTI9iKuoviNWWKNXNH20xJojDX4aHn1iPXHU11QiioXGeQGpAVynLTsV4IXObn0hdACrEZPuojJnRfS7Ji+mND05tGvkDxwSW1T3QxuZgHKfArrrvA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svmc1-0000uN-ME for bug-guile@gnu.org; Tue, 01 Oct 2024 19:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Taylan Kammer Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 01 Oct 2024 23:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72366 X-GNU-PR-Package: guile Original-Received: via spool by 72366-submit@debbugs.gnu.org id=B72366.17278264923475 (code B ref 72366); Tue, 01 Oct 2024 23:49:01 +0000 Original-Received: (at 72366) by debbugs.gnu.org; 1 Oct 2024 23:48:12 +0000 Original-Received: from localhost ([127.0.0.1]:54427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svmbD-0000ty-PJ for submit@debbugs.gnu.org; Tue, 01 Oct 2024 19:48:12 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:41877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svmbB-0000tp-Du for 72366@debbugs.gnu.org; Tue, 01 Oct 2024 19:48:09 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42cb1e3b449so7949815e9.3 for <72366@debbugs.gnu.org>; Tue, 01 Oct 2024 16:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727826429; x=1728431229; darn=debbugs.gnu.org; h=in-reply-to:content-language:references:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=q+vu0zKnS/O/kPe87Y/hgimdt8bkmew2K55hnRpsGHA=; b=EZz7b5XQEUoTkAyuS5l6hSgZqnhe8k4VNVH1r6yp9NNEzSgvjxRT6yXOh6EipBxTfe SFoyKxYkclaLT2e8J7KcjT1Rajk5BGvNjEyvsKQcjPFbuYzhnn4T/inZHet7yAdiycYc w/F7AhrR01sYswHdYE9UWi2yfFlibkT5fng8qb1qMxOK3wZKBhfjfqwZKRZxUMn6jaV8 UbUVNNs83vNEsGMRtF3I8+WAaKpmB6lVmIsdgvH6ATCHqJuOjnyVjJ5EDVHVu/acn4Xn 7lExCf5UbwUIVrPVUUyLAP1lWHrZStTHlGQIxRY/zhnCUfw91emQUO2wDIDWldfaDjJQ P1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727826429; x=1728431229; h=in-reply-to:content-language:references:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q+vu0zKnS/O/kPe87Y/hgimdt8bkmew2K55hnRpsGHA=; b=go7G2I7amCixxgbie+76iOs/QwXkq3VOykuE6025TzuwxYqw3v3Xsjyx+qCMf+k7A6 y/RpaZvmqJad8+lpRpT43PsTgJXNxTGj5hBNIZthxB5i6tEEcbe5cHKw+qA8Jl7xwIPu 5YHMeVtsnqQm8Dzwv4+6Mww5l2y4iEsUp6II0Qyuo4ZWZ42e5VzDQGySorom+4wld+Ze SpZ2UkThQjx9TJ8pHfAIlKd7SRFs8ZZ2X6Cplf2JqjM/htyX6lCTAMjOWeB+qNcVoFpe z80uN6++zFOXQguSenhXn50NDShhhgpxwaF1qi2E/7yD5NzIRrtWIP4MRMlhdkQzE2xV APmA== X-Forwarded-Encrypted: i=1; AJvYcCUVYwcJLNxkq3sPzYkfkh26psxv2KEIL2QXhq0JAOi7QnGI96qJgNxzJnU//3yaVJ8wxJCIgQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyBrhlpZF+WLVpYqD3FCJGMgG667fDC5bS8DQ+gx4WsZSd714+O 81HYeaFm5CIHWaHdUUIqylFGLWuI7obCsGh4CyhaCRCAHM6pe4NJO+H11FH7Jok= X-Google-Smtp-Source: AGHT+IG/hF4TcXGFwrmm4S/HAYsXPCjWRAxNk5QvafUTEYCWVvMn0EtEMwk81PWGHjn8Tm0LqiFn0w== X-Received: by 2002:a05:600c:3552:b0:42c:aeee:d8ef with SMTP id 5b1f17b1804b1-42f790970abmr2266985e9.9.1727826428545; Tue, 01 Oct 2024 16:47:08 -0700 (PDT) Original-Received: from ?IPV6:2003:106:8f04:c300:95ac:529d:6db3:196b? (p200301068f04c30095ac529d6db3196b.dip0.t-ipconnect.de. [2003:106:8f04:c300:95ac:529d:6db3:196b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f79ec039asm3075215e9.12.2024.10.01.16.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 16:47:07 -0700 (PDT) Content-Language: en-US In-Reply-To: <6e4c71b8-e46a-4358-8daf-2f6e1d9de1b5@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:11017 Archived-At: This is a multi-part message in MIME format. --------------PiXVo7A2go6KMr0sYeVxfDEE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30.09.2024 16:04, Taylan Kammer wrote: > I've also decided to remove the check on whether the begin-name is true, because as per spec it's not allowed to be false anyway, and IMO it should call the bad-end-name callback if the begin-name was explicitly passed as #f but the end-name is not also #f. > A little update on this: Removing that check entirely was stupid, because the value defaults to #f when not provided. So, an explicit #f is allowed by `test-end` as an implementation detail, and is equivalent to not providing a name. Thus, starting a test suite with a name "foo" and ending it with explicit name #f is valid. However, I've changed the code of `test-end` to check whether the `end-name` was provided rather than whether the `begin-name` was provided. Thus, starting a test suite with an explicit name #f and ending it with a non-#f name WILL raise an error. If `test-end` is provided a name and it is non-#f, then it MUST match the name passed to `test-begin`. - Taylan --------------PiXVo7A2go6KMr0sYeVxfDEE Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 30.09.2024 16:04, Taylan Kammer wrote: 
I've also decided to remove the check on whether the begin-name is true, because as per spec it's not allowed to be false anyway, and IMO it should call the bad-end-name callback if the begin-name was explicitly passed as #f but the end-name is not also #f.

A little update on this:

Removing that check entirely was stupid, because the value defaults to #f when not provided. So, an explicit #f is allowed by `test-end` as an implementation detail, and is equivalent to not providing a name. Thus, starting a test suite with a name "foo" and ending it with explicit name #f is valid.

However, I've changed the code of `test-end` to check whether the `end-name` was provided rather than whether the `begin-name` was provided. Thus, starting a test suite with an explicit name #f and ending it with a non-#f name WILL raise an error. If `test-end` is provided a name and it is non-#f, then it MUST match the name passed to `test-begin`.

- Taylan

--------------PiXVo7A2go6KMr0sYeVxfDEE--