From: Tomas Volf <~@wolfsden.cz>
To: 74385@debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>, Janneke Nieuwenhuizen <janneke@gnu.org>
Subject: bug#74385: [PATCH 4/4] srfi-64: Report failed tests in (standards)Errors format.
Date: Sat, 16 Nov 2024 18:42:07 +0100 [thread overview]
Message-ID: <20241116174210.9160-4-~@wolfsden.cz> (raw)
In-Reply-To: <20241116174210.9160-1-~@wolfsden.cz>
There is a page in the GNU Standards document regarding the format of error
messages. Both GNU Emacs and Vim are able to parse it and support jumping to
next/previous error. My version did not produce a line in this format for
failed tests and this commit rectifies that.
* module/srfi/srfi-64.scm (test-on-test-end-simple)[non-passed]: Write
out (standards)Errors compatible line.
Reported-by: Janneke Nieuwenhuizen <janneke@gnu.org>
---
module/srfi/srfi-64.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm
index 203db49ea..98f6c8114 100644
--- a/module/srfi/srfi-64.scm
+++ b/module/srfi/srfi-64.scm
@@ -28,6 +28,7 @@
#:use-module (ice-9 format)
#:use-module (ice-9 match)
#:use-module (srfi srfi-1)
+ #:use-module (srfi srfi-2)
#:use-module (srfi srfi-9)
#:use-module (srfi srfi-26)
#:use-module (srfi srfi-71)
@@ -431,6 +432,10 @@ instead."
result-kind
(test-runner-test-name runner))
(unless (member result-kind '(pass xfail))
+ (and-let* ((file (test-result-ref runner 'source-file))
+ (line (test-result-ref runner 'source-line)))
+ ;; Satisfy (standards)Errors
+ (format #t "~a:~a: unexpected result~%" file line))
(maybe-print-prop 'source-file #f "~a")
(maybe-print-prop 'source-line #f "~a")
(maybe-print-prop 'source-form #t "~y")
--
2.46.0
prev parent reply other threads:[~2024-11-16 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 17:39 bug#74385: [PATCH 0/4] Patches for SRFI-64 Tomas Volf
2024-11-16 17:42 ` bug#74385: [PATCH 1/4] srfi-64: Fix maybe-print-prop Tomas Volf
2024-11-16 17:42 ` bug#74385: [PATCH 2/4] srfi-64: Use ~s when printing some properties Tomas Volf
2024-11-16 17:42 ` bug#74385: [PATCH 3/4] srfi-64: Export define-equality-test Tomas Volf
2024-11-16 17:42 ` Tomas Volf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20241116174210.9160-4-~@wolfsden.cz' \
--to=~@wolfsden.cz \
--cc=74385@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).