From: Tomas Volf <~@wolfsden.cz>
To: 72547@debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: bug#72547: [PATCH 8/9] Do not depend on tmpnam in posix.test.
Date: Sat, 10 Aug 2024 00:54:34 +0200 [thread overview]
Message-ID: <20240809225435.19028-8-~@wolfsden.cz> (raw)
In-Reply-To: <20240809225435.19028-1-~@wolfsden.cz>
`tmpnam' is a deprecated procedure that can be excluded during a
configure (`--disable-tmpnam'). There currently was a single test
relying on it, and therefore failing is such configuration. This commit
switches to mkstemp instead.
* test-suite/tests/posix.test ("system*"): Use mkstemp instead of
tmpnam.
---
test-suite/tests/posix.test | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test-suite/tests/posix.test b/test-suite/tests/posix.test
index 95692eeb1..c4360b79e 100644
--- a/test-suite/tests/posix.test
+++ b/test-suite/tests/posix.test
@@ -365,7 +365,8 @@
(pass-if-equal "https://bugs.gnu.org/52835"
"bong\n"
- (let ((file (tmpnam)))
+ (let* ((port (mkstemp "T-XXXXXX"))
+ (file (port-filename port)))
;; Redirect stdout and stderr to FILE.
(define status
(call-with-output-file file
@@ -376,8 +377,9 @@
(lambda ()
(system* "sh" "-c" "echo bong >&2"))))))))
+ (delete-file file)
(and (zero? (status:exit-val status))
- (call-with-input-file file get-string-all))))
+ (get-string-all port))))
(pass-if-equal "https://bugs.gnu.org/63024"
0
--
2.45.2
next prev parent reply other threads:[~2024-08-09 22:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 22:47 bug#72547: [PATCH 0/9] Make test suite pass on macOS Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of 1 Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 2/9] tests: Skip tests of abstract Unix sockets on Darwin Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 3/9] tests: Skip hole-related port tests " Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 4/9] filesys.c: Fix readlink for ports " Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 5/9] tests: Skip mkdtemp test for invalid template " Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 6/9] tests: Fix spawn with #:environment on MacOS Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 7/9] tests: Fix spawn if file not found with Gnulib Tomas Volf
2024-08-09 22:54 ` Tomas Volf [this message]
2024-08-09 22:54 ` bug#72547: [PATCH 9/9] posix.c: Set errno when pipe2 is not available and flags provided Tomas Volf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20240809225435.19028-8-~@wolfsden.cz' \
--to=~@wolfsden.cz \
--cc=72547@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).