From: Tomas Volf <~@wolfsden.cz>
To: 72547@debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: bug#72547: [PATCH 7/9] tests: Fix spawn if file not found with Gnulib.
Date: Sat, 10 Aug 2024 00:54:33 +0200 [thread overview]
Message-ID: <20240809225435.19028-7-~@wolfsden.cz> (raw)
In-Reply-To: <20240809225435.19028-1-~@wolfsden.cz>
On Darwin posix_spawnp is not considered secured and therefore we
fallback to Gnulib's version. That one however does not return ENOENT
when the file does not exist, but PID of the child process. This seems
to be allowed by the standard.
* test-suite/tests/posix.test (skip-on-darwin): New procedure.
("spawn")["file not file"]: Skip on Darwin.
---
test-suite/tests/posix.test | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/test-suite/tests/posix.test b/test-suite/tests/posix.test
index ac5a3b289..95692eeb1 100644
--- a/test-suite/tests/posix.test
+++ b/test-suite/tests/posix.test
@@ -22,6 +22,9 @@
#:use-module (test-suite lib)
#:use-module ((rnrs io ports) #:select (get-string-all)))
+(define (skip-on-darwin)
+ (when (string-ci=? "darwin" (vector-ref (uname) 0))
+ (throw 'untested)))
;; FIXME: The following exec tests are disabled since on an i386 debian with
;; glibc 2.3.2 they seem to interact badly with threads.test, the latter
@@ -475,6 +478,11 @@
(pass-if-equal "file not found"
ENOENT
+ ;; Actually "skip-if-posix_spawn-replaced" would be preferred, since the
+ ;; behavior below is not implemented in gnulib, but I do not know how to
+ ;; write such test. However due to posix_spawnp being buggy on MacOS it is
+ ;; always replaced, so whatever.
+ (skip-on-darwin)
(catch 'system-error
(lambda ()
(spawn "this-does-not-exist" '("nope")
--
2.45.2
next prev parent reply other threads:[~2024-08-09 22:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 22:47 bug#72547: [PATCH 0/9] Make test suite pass on macOS Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of 1 Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 2/9] tests: Skip tests of abstract Unix sockets on Darwin Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 3/9] tests: Skip hole-related port tests " Tomas Volf
2024-10-20 19:18 ` Ludovic Courtès
2024-10-21 21:31 ` Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 4/9] filesys.c: Fix readlink for ports " Tomas Volf
2024-10-20 19:20 ` Ludovic Courtès
2024-08-09 22:54 ` bug#72547: [PATCH 5/9] tests: Skip mkdtemp test for invalid template " Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 6/9] tests: Fix spawn with #:environment on MacOS Tomas Volf
2024-08-09 22:54 ` Tomas Volf [this message]
2024-08-09 22:54 ` bug#72547: [PATCH 8/9] Do not depend on tmpnam in posix.test Tomas Volf
2024-08-09 22:54 ` bug#72547: [PATCH 9/9] posix.c: Set errno when pipe2 is not available and flags provided Tomas Volf
2024-10-20 19:19 ` Ludovic Courtès
2024-10-20 19:17 ` bug#72547: [PATCH 0/9] Make test suite pass on macOS Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20240809225435.19028-7-~@wolfsden.cz' \
--to=~@wolfsden.cz \
--cc=72547@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).