From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Volf <~@wolfsden.cz> Newsgroups: gmane.lisp.guile.bugs Subject: bug#72547: [PATCH 1/9] tests: Check TCP_NODELAY for non-zero instead of 1. Date: Sat, 10 Aug 2024 00:54:27 +0200 Message-ID: <20240809225435.19028-1-~@wolfsden.cz> References: <20240809224744.18772-1-~@wolfsden.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21504"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tomas Volf <~@wolfsden.cz> To: 72547@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sat Aug 10 00:56:12 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scYWo-0005Q3-Rq for guile-bugs@m.gmane-mx.org; Sat, 10 Aug 2024 00:56:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1scYWG-000607-Ex; Fri, 09 Aug 2024 18:55:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scYWE-0005zN-TP for bug-guile@gnu.org; Fri, 09 Aug 2024 18:55:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1scYWE-00020b-Jl for bug-guile@gnu.org; Fri, 09 Aug 2024 18:55:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=QY8y4eR+BPWFTgiCt6GDciSaJsXg6ujDiDXhiE9gdtE=; b=M+g9wTHUA1nmRKEmbKg4BkdB8b5YRuPXB08o1uNYzk31iPkeuNeMuSGl4kg0SVCJ7SjrMLZ7o/cx6TSlmuESVD7hcRZl/VaB75mRLr5vIvBYtwqWTQiA2ajnoDmS89nXBS2x55/a7phIRJwJW50ttsROq5KOQ9SS7KWTsO6RFBvvPbFf8fT2iWO5+D4Y0M1UB5sUtWhTTnEWXVQMse4hVD0io3IXP3B9KkVMNzh3XdKH02VwbymW9dUhf/DH1RyxklBEAki63nOxoHKv53moYzTkHU/0XIwHvqka62Q6tO/m37b2dHMN1u08tAiltVzor8EgRl5yU0uNqltnpqZjKw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1scYWg-00087v-1B for bug-guile@gnu.org; Fri, 09 Aug 2024 18:56:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <20240809224744.18772-1-~@wolfsden.cz> Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 09 Aug 2024 22:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72547 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 72547-submit@debbugs.gnu.org id=B72547.172324411331092 (code B ref 72547); Fri, 09 Aug 2024 22:56:01 +0000 Original-Received: (at 72547) by debbugs.gnu.org; 9 Aug 2024 22:55:13 +0000 Original-Received: from localhost ([127.0.0.1]:38721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scYVs-00085C-QR for submit@debbugs.gnu.org; Fri, 09 Aug 2024 18:55:13 -0400 Original-Received: from wolfsden.cz ([37.205.8.62]:33506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1scYVq-00084m-AR for 72547@debbugs.gnu.org; Fri, 09 Aug 2024 18:55:12 -0400 Original-Received: by wolfsden.cz (Postfix, from userid 104) id 1F2EC2AA0B5; Fri, 9 Aug 2024 22:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1723244080; bh=sU8D9UF0jGYhDw418emh7rlKioPaADNqiK6610sKS6o=; h=From:To:Cc:Subject:Date; b=VlFdtvTNOECBb5JYd2iuWldTuKgNwVB6IH/0foYAGD+GVfY6Q1Ww7XcL/AWpWYHqZ m77yl5b8majRa8ICf/QNv/OOgdaNAO83nwh0XG/EJ+wRiwxTbgrhharP5qvhIJitz9 DwPNdZhMRxKAkYxrnycnJsH3UcXiZxVtGwK+0CMv+PFFuLiGd38zl5z3+pw6DsrgGA xpNcFSiCNsMBBAm6r0LY1LgNzwayHiTrRPHla0oN3vhp192m41w+Vbb2Arh/0A7J7M RZcyNF/2Mx15G/B8OYRRnfixxj/QtI/T2KNFpjC29ZVHlH2p+nV9ZVANISW0Mznxn5 j1MVwOY9Ks+PAxm0c0cNx/btBSLPdE3WBfAzhM4uosYcXiIocecSXyRqBVft4OXirq SFfc3ulW3ZKG9hygXiDV+GAIjgmRNNEXQ7tJcp/DN3vei/vK322WZV/BfqX8Z0tF9O +UwazdgLKk/Qw0hymYgYjvHwYs92nKgprGFmIGL2OCs5IAgzMtjEyJwDG36JsguSOI KXItTIgIPGj2qgXSctQdmXkzUjSKGU+jcfMo8YimEyKNiqAH/s59uCCYEjYklwIkWI i0j332Rtj989iyfVM5sHzvYi5C+0GDipn6RNNexK99S+vQdSMhpXbanSJ2fDJX4qbV IcV0X7NhPLl/ITO5rxo+z7H8= Original-Received: from localhost (unknown [146.70.134.146]) by wolfsden.cz (Postfix) with ESMTPSA id B03462A9C21; Fri, 9 Aug 2024 22:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1723244079; bh=sU8D9UF0jGYhDw418emh7rlKioPaADNqiK6610sKS6o=; h=From:To:Cc:Subject:Date; b=kH6318hUXwVnexveZW1uTHGqHOt8srQ2fkLKbyyPqXkWzg7wQM7mfV5s0vkemYGTu QQxVjP61yBG5He9SelClPMiuy99+4m+XDARdy1rXf28Ds03pDvYG43VFxntO31/bzA m0F+SnT2sUf/8D+Xh7yAqZefSEG6+peXLkuZvJkb1EeldjfKz4eW1x6DHnXTEcnDIa Buu3BYyF7XlXuHczpJ4aSSJvi/pO6lJYD2lV4McPUTy7W/2b6CHxV4GOVYCRP4bdL8 1HssTd64id6lVRjmefGQ7ckXIg+b8/CuAkoT9SkOzEoSaCnMVcH3RyY/15BxCsCSuu 5HOQLyj9lJUFaHIBBcqyg8lMyOrnB2jeiPd7rQBX5TWCgK928mXGAp/t/2Gp1o8nNM 4Rux2c3mSHKoMbela/rh093Mb7OedlJ/+eNHh79tzYI3hnbdD0jWKTCLV3IFcheC3c rGZY4Nr9WJ8gIyEIv1IFZRVsKhEImWZqxcX3FqS17ZW1cpR2XYGbsekAo6Sw+AirOH mcvzgeIgmtZXHRn3PZk27CHOsFnCpydg0TZSrv2tzPqF3QMqGxKBJ3dA1NCnLMmL2w TY/XYC/WgA+79IQqTmKNGvqLTJCUzoVLcsoTb6J8gVsjmUlWF6DxiSnQCZhWQTPrJx wSkq3icmg+SK2QFWa7tr80sc= X-Mailer: git-send-email 2.45.2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10943 Archived-At: POSIX does not explicitly say that stored value using setsockopt will be returned by getsockopt. At least for TCP_NODELAY on Darwin they do differ. Darwin returns internal define TF_NODELAY (4) instead of 1 the test expected. Since for boolean flags "non-zero is true", rewrite the test to check just that. * test-suite/tests/00-socket.test ("setsockopt AF_INET") ["IPPROTO_TCP TCP_NODELAY"]: Check for non-zero value from getsockopt. --- test-suite/tests/00-socket.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-suite/tests/00-socket.test b/test-suite/tests/00-socket.test index b3692f61a..17e686225 100644 --- a/test-suite/tests/00-socket.test +++ b/test-suite/tests/00-socket.test @@ -147,7 +147,7 @@ (pass-if "IPPROTO_TCP TCP_NODELAY" (let ((sock (socket AF_INET SOCK_STREAM 0))) (setsockopt sock IPPROTO_TCP TCP_NODELAY 1) - (eqv? 1 (getsockopt sock IPPROTO_TCP TCP_NODELAY)))))) + (not (eqv? 0 (getsockopt sock IPPROTO_TCP TCP_NODELAY))))))) ;;; -- 2.45.2