From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Volf <~@wolfsden.cz> Newsgroups: gmane.lisp.guile.bugs Subject: bug#71796: [PATCH] Do not depend on tmpnam in posix.test. Date: Thu, 27 Jun 2024 15:43:35 +0200 Message-ID: <20240627134335.26287-1-~@wolfsden.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tomas Volf <~@wolfsden.cz> To: 71796@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Thu Jun 27 15:45:35 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMpRP-0005DI-2r for guile-bugs@m.gmane-mx.org; Thu, 27 Jun 2024 15:45:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMpQr-0005EL-KR; Thu, 27 Jun 2024 09:45:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMpQp-0005DT-VQ for bug-guile@gnu.org; Thu, 27 Jun 2024 09:44:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMpQp-0008Cl-MT for bug-guile@gnu.org; Thu, 27 Jun 2024 09:44:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMpQs-0001Yl-EN for bug-guile@gnu.org; Thu, 27 Jun 2024 09:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 27 Jun 2024 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71796 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17194958525902 (code B ref -1); Thu, 27 Jun 2024 13:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Jun 2024 13:44:12 +0000 Original-Received: from localhost ([127.0.0.1]:41315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMpQ4-0001X7-FV for submit@debbugs.gnu.org; Thu, 27 Jun 2024 09:44:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:33718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1sMpQ2-0001Wz-Er for submit@debbugs.gnu.org; Thu, 27 Jun 2024 09:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sMpPz-0004bx-81 for bug-guile@gnu.org; Thu, 27 Jun 2024 09:44:07 -0400 Original-Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sMpPw-0007sH-UJ for bug-guile@gnu.org; Thu, 27 Jun 2024 09:44:06 -0400 Original-Received: by wolfsden.cz (Postfix, from userid 104) id 8ECB12A8732; Thu, 27 Jun 2024 13:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1719495841; bh=xiIzO1bMtvZnR6hCg8nJFgf3VS4wt7ZXD1lNBJm7l6o=; h=From:To:Cc:Subject:Date; b=QMZS1PuJOLVv5b0kpa6VTWJ8may9jsh1VbxywgL1bg88YTTA3VquGMj2PVbrsP5wb IFdC1KlaOxLAXHPUIHm3PbrBm1dPxhJhNqJ/dzHOc0bt7r7iMErDjPeLxRzjddXgK2 XK/AqSkS4Ly8y440fjPnLx4aCk0+J/hzy0DBC1bVW3A39WpPshXZEOyZEz8hrFWfl8 7/9NaBvkSnNqPESRSAo/xgbpPK4bltvUoq8H3PKNgF0iCuOyECGQGkNw94V1/0X0hY o+NISbqw9CCFLLk0rhIY62tQ5jcFnOwY9FzYYEoYsM8K2JY3kXHxQfmRUohbHO1gpx UfZ7lzeatAPwBNauLrppliffKhXfhUmFW4473XnbtRE+IV6LT/7OqgFlbuQZkXvWxe AOgZxdVOvb1AvewHvtAnxuZYMguYvvyEqH1qWHMnLtfivz/lhvYaDAlJYLBgAN9aPG GGbvW7VsG0OMsIBWxCAnBhBTDFzPCDUOhT9H8Vkm+thXdQ0nZEmV4UUsbkbkip2UXy b4NJZ9ehDZ1Dn9dicRCRTR8jA+u1HwAfpVhnGrBjdwt5hVMnzY1u8CzXqJLizFl+lI K0QjioT5KuIF/9zXyVL8Yn14kB1AnxQCy54qounIRxLC+IDUUX7BR3I6ut3+zGCsf3 dvn088ZDHCRNdY9XmmJK0/gA= Original-Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 264542A8428; Thu, 27 Jun 2024 13:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1719495841; bh=xiIzO1bMtvZnR6hCg8nJFgf3VS4wt7ZXD1lNBJm7l6o=; h=From:To:Cc:Subject:Date; b=QMZS1PuJOLVv5b0kpa6VTWJ8may9jsh1VbxywgL1bg88YTTA3VquGMj2PVbrsP5wb IFdC1KlaOxLAXHPUIHm3PbrBm1dPxhJhNqJ/dzHOc0bt7r7iMErDjPeLxRzjddXgK2 XK/AqSkS4Ly8y440fjPnLx4aCk0+J/hzy0DBC1bVW3A39WpPshXZEOyZEz8hrFWfl8 7/9NaBvkSnNqPESRSAo/xgbpPK4bltvUoq8H3PKNgF0iCuOyECGQGkNw94V1/0X0hY o+NISbqw9CCFLLk0rhIY62tQ5jcFnOwY9FzYYEoYsM8K2JY3kXHxQfmRUohbHO1gpx UfZ7lzeatAPwBNauLrppliffKhXfhUmFW4473XnbtRE+IV6LT/7OqgFlbuQZkXvWxe AOgZxdVOvb1AvewHvtAnxuZYMguYvvyEqH1qWHMnLtfivz/lhvYaDAlJYLBgAN9aPG GGbvW7VsG0OMsIBWxCAnBhBTDFzPCDUOhT9H8Vkm+thXdQ0nZEmV4UUsbkbkip2UXy b4NJZ9ehDZ1Dn9dicRCRTR8jA+u1HwAfpVhnGrBjdwt5hVMnzY1u8CzXqJLizFl+lI K0QjioT5KuIF/9zXyVL8Yn14kB1AnxQCy54qounIRxLC+IDUUX7BR3I6ut3+zGCsf3 dvn088ZDHCRNdY9XmmJK0/gA= X-Mailer: git-send-email 2.45.1 Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10870 Archived-At: `tmpnam' is a deprecated procedure that can be excluded during a configure (`--disable-tmpnam'). There currently was a single test relying on it, and therefore failing is such configuration. This commit switches to mkstemp instead. * test-suite/tests/posix.test ("system*"): Use mkstemp instead of tmpnam. --- test-suite/tests/posix.test | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test-suite/tests/posix.test b/test-suite/tests/posix.test index 18dad8902..0d75eb145 100644 --- a/test-suite/tests/posix.test +++ b/test-suite/tests/posix.test @@ -362,7 +362,8 @@ (pass-if-equal "https://bugs.gnu.org/52835" "bong\n" - (let ((file (tmpnam))) + (let* ((port (mkstemp "T-XXXXXX")) + (file (port-filename port))) ;; Redirect stdout and stderr to FILE. (define status (call-with-output-file file @@ -373,8 +374,9 @@ (lambda () (system* "sh" "-c" "echo bong >&2")))))))) + (delete-file file) (and (zero? (status:exit-val status)) - (call-with-input-file file get-string-all)))) + (get-string-all port)))) (pass-if-equal "https://bugs.gnu.org/63024" 0 -- 2.45.1