From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Josselin Poiret via "Bug reports for GUILE, GNU's Ubiquitous Extension Language" Newsgroups: gmane.lisp.guile.bugs Subject: bug#52835: [PATCH v4 3/4] Remove useless closing code in start_child. Date: Sat, 28 May 2022 14:46:33 +0200 Message-ID: <20220528124634.17353-4-dev@jpoiret.xyz> References: <20220207165543.12723-1-dev@jpoiret.xyz> <20220528124634.17353-1-dev@jpoiret.xyz> Reply-To: Josselin Poiret Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27879"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52835@debbugs.gnu.org To: Josselin Poiret , Timothy Sample Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sat May 28 14:47:36 2022 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuvqy-00073g-Bu for guile-bugs@m.gmane-mx.org; Sat, 28 May 2022 14:47:36 +0200 Original-Received: from localhost ([::1]:47376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuvqw-0003rV-56 for guile-bugs@m.gmane-mx.org; Sat, 28 May 2022 08:47:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuvqR-0003qT-J4 for bug-guile@gnu.org; Sat, 28 May 2022 08:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuvqR-00048z-Ap for bug-guile@gnu.org; Sat, 28 May 2022 08:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuvqR-00010e-8z for bug-guile@gnu.org; Sat, 28 May 2022 08:47:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 28 May 2022 12:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52835 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 52835-submit@debbugs.gnu.org id=B52835.16537420183850 (code B ref 52835); Sat, 28 May 2022 12:47:03 +0000 Original-Received: (at 52835) by debbugs.gnu.org; 28 May 2022 12:46:58 +0000 Original-Received: from localhost ([127.0.0.1]:36612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuvqM-0000zx-Ht for submit@debbugs.gnu.org; Sat, 28 May 2022 08:46:58 -0400 Original-Received: from jpoiret.xyz ([206.189.101.64]:34594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuvqK-0000za-9I for 52835@debbugs.gnu.org; Sat, 28 May 2022 08:46:56 -0400 Original-Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 2A2081852FC; Sat, 28 May 2022 12:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1653742015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PD0X5NCtWede9t396/8icAU7NcQpJXOWrnNGNcLqlOs=; b=vptl/SyzHRTDXqtlzafuPdMdmQBQ2Rls8+XaQutTBpRMalG+07LLtRSaBa23KR/uqNGAxg wxLbDibHouM90Ofc/mAJCtEsOvMu/jgRrKuA0rhoE2tQoGtRvAmHwnO0VHlklWsmdb5H0Y H/+0TrH5xCwKZZAc+6o9j47TgaNgdHFeHphzPvmoclDmUBEz25QtwkyTZrsX04kt4/HQ18 t/+G+ln631j4rNsBHvGAhPenKiZsJWJejV8WK04qEilmRUf45hk82ispJWPgYV9kgLaQMI GkOGcc1WFV5CS01l04nYuDPgKLyxlCjLNjFxf3Avk32aOtJLTykvYyUJ9z/BKQ== In-Reply-To: <20220528124634.17353-1-dev@jpoiret.xyz> Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:10284 Archived-At: * libguile/posix.c (start_child): We're closing all fds anyway, no need to try to close some specific ones beforehand. --- libguile/posix.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index 155ad09b7..94a043cca 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -1363,12 +1363,6 @@ start_child (const char *exec_file, char **exec_argv, child. Return directly in either case. */ return pid; - /* The child. */ - if (reading) - close (c2p[0]); - if (writing) - close (p2c[1]); - /* Close all file descriptors in ports inherited from the parent except for in, out, and err. Heavy-handed, but robust. */ while (max_fd--) -- 2.36.0