From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Josselin Poiret via "Bug reports for GUILE, GNU's Ubiquitous Extension Language" Newsgroups: gmane.lisp.guile.bugs Subject: bug#52835: [PATCH v2 2/2] Remove unused renumber_file_descriptor Date: Mon, 27 Dec 2021 22:49:59 +0100 Message-ID: <20211227214959.15324-1-dev@jpoiret.xyz> References: <552de70f16142c8a42cde0a449549eac42e48485.1640638819.git.dev@jpoiret.xyz> Reply-To: Josselin Poiret Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33627"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52835@debbugs.gnu.org To: Josselin Poiret Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Mon Dec 27 22:51:21 2021 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1xtp-0008Vj-7w for guile-bugs@m.gmane-mx.org; Mon, 27 Dec 2021 22:51:21 +0100 Original-Received: from localhost ([::1]:38124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1xtn-0005zw-2g for guile-bugs@m.gmane-mx.org; Mon, 27 Dec 2021 16:51:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1xtW-0005zo-Sv for bug-guile@gnu.org; Mon, 27 Dec 2021 16:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1xtW-0006qd-JN for bug-guile@gnu.org; Mon, 27 Dec 2021 16:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1xtW-0006N8-Gf for bug-guile@gnu.org; Mon, 27 Dec 2021 16:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 27 Dec 2021 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52835 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 52835-submit@debbugs.gnu.org id=B52835.164064180724404 (code B ref 52835); Mon, 27 Dec 2021 21:51:02 +0000 Original-Received: (at 52835) by debbugs.gnu.org; 27 Dec 2021 21:50:07 +0000 Original-Received: from localhost ([127.0.0.1]:44479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1xsc-0006LX-Px for submit@debbugs.gnu.org; Mon, 27 Dec 2021 16:50:06 -0500 Original-Received: from jpoiret.xyz ([206.189.101.64]:43738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1xsa-0006LL-My for 52835@debbugs.gnu.org; Mon, 27 Dec 2021 16:50:05 -0500 Original-Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 01BE8184F5B; Mon, 27 Dec 2021 21:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1640641803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMe6KAudtvA5vNnkI+Rkl+ZhPAPII95GLnzT30kKsyw=; b=XgH1BkmJSyxEpLKsFzM9hL0Pp/2gbG+8gjAMQYnlNcHBCgdDmM04bfaWxg5bhIp9t+1wd5 34YC1CTmdeRpw2g+qlG08ozjt0kPk+T7PaJGNWgwGmqM50PYASJwuezMA3nLo+2MC/R3tr BgtXdm9Xgqv/B+Qivwm96kN0kdCdXaPeTdJ5QAhSiy6npt6MGKC+Uw8JCotKxF9ytG8CT5 Hzhlg74if7Zxdn2KKbqv3UrABdSIPKiGqHdjbpi5nIokz36m1SXeu//cwLtgmGGFSvpTjG Oq0NaxhrrIA1aSCXEdYbhcTRzAbilpfReE7+0lzS/cnzRCTnrpdX5Ry6F+PFnw== In-Reply-To: <552de70f16142c8a42cde0a449549eac42e48485.1640638819.git.dev@jpoiret.xyz> X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:10231 Archived-At: * libguile/posix.c (renumber_file_descriptor): Remove it. --- Sorry for the noise, but I just saw that this patch omitted a closing */, here is a fixed version. libguile/posix.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/libguile/posix.c b/libguile/posix.c index 148ebeb3d..1d9996565 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -1279,36 +1279,6 @@ SCM_DEFINE (scm_fork, "primitive-fork", 0, 0, 0, #undef FUNC_NAME #endif /* HAVE_FORK */ -#ifdef HAVE_FORK -/* 'renumber_file_descriptor' is a helper function for 'start_child' - below, and is specialized for that particular environment where it - doesn't make sense to report errors via exceptions. It uses dup(2) - to duplicate the file descriptor FD, closes the original FD, and - returns the new descriptor. If dup(2) fails, print an error message - to ERR and abort. */ -static int -renumber_file_descriptor (int fd, int err) -{ - int new_fd; - - do - new_fd = dup (fd); - while (new_fd == -1 && errno == EINTR); - - if (new_fd == -1) - { - /* At this point we are in the child process before exec. We - cannot safely raise an exception in this environment. */ - const char *msg = strerror (errno); - fprintf (fdopen (err, "a"), "start_child: dup failed: %s\n", msg); - _exit (127); /* Use exit status 127, as with other exec errors. */ - } - - close (fd); - return new_fd; -} -#endif /* HAVE_FORK */ - #ifdef HAVE_FORK #define HAVE_START_CHILD 1 /* Since Guile uses threads, we have to be very careful to avoid calling -- 2.34.0