unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: David Pirotte <david@altosw.be>
To: 29669@debbugs.gnu.org
Subject: bug#29669: repl-print - requet for iprovement
Date: Mon, 11 Dec 2017 21:36:15 -0200	[thread overview]
Message-ID: <20171211213615.7bca6fc8@capac> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 287 bytes --]

Hello,

Attached a patch so repl-print becomes 'friendly' wrt large (huge) lists,
arrays, srfi-4 bytevectors ...

	I looked at the documentation but I could not spot anything/places where
	things would need to be changed wrt the above patch?

	Dito wrt tests?

Thanks,
David

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Updating-repl-print-to-use-truncated-print.patch --]
[-- Type: text/x-patch, Size: 1780 bytes --]

From d920d22efe3e77d23004122e21cec420c402f531 Mon Sep 17 00:00:00 2001
From: David Pirotte <david@altosw.be>
Date: Mon, 11 Dec 2017 21:28:24 -0200
Subject: [PATCH] Updating repl-print to use truncated-print

* module/system/repl/common.scm (repl-print): Use (truncated-print val),
  not (write val).  With this update, repl-print becomes 'friendly' wrt
  large (huge) lists, arrays, srfi-4 butevoectors ...
---
 module/system/repl/common.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/module/system/repl/common.scm b/module/system/repl/common.scm
index 42d5c24ae..47799957d 100644
--- a/module/system/repl/common.scm
+++ b/module/system/repl/common.scm
@@ -1,6 +1,6 @@
 ;;; Repl common routines
 
-;; Copyright (C) 2001, 2008-2016  Free Software Foundation, Inc.
+;; Copyright (C) 2001, 2008-2017  Free Software Foundation, Inc.
 
 ;;; This library is free software; you can redistribute it and/or
 ;;; modify it under the terms of the GNU Lesser General Public
@@ -28,6 +28,7 @@
   #:autoload (language tree-il optimize) (optimize)
   #:use-module (ice-9 control)
   #:use-module (ice-9 history)
+  #:use-module (ice-9 pretty-print)
   #:export (<repl> make-repl repl-language repl-options
             repl-tm-stats repl-gc-stats repl-debug
             repl-welcome repl-prompt
@@ -223,7 +224,7 @@ See <http://www.gnu.org/licenses/lgpl.html>, for more details.")
           ;; should be printed with the generic printer, `write'. The
           ;; language-printer is something else: it prints expressions of
           ;; a given language, not the result of evaluation.
-          (write val)
+          (truncated-print val)
           (newline))))))
 
 (define (repl-option-ref repl key)
-- 
2.15.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2017-12-11 23:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 23:36 David Pirotte [this message]
2018-07-01 16:26 ` bug#29669: repl-print - requet for iprovement Ludovic Courtès
2018-07-05  7:49   ` Andy Wingo
2018-08-04  2:37     ` David Pirotte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211213615.7bca6fc8@capac \
    --to=david@altosw.be \
    --cc=29669@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).