From: Sergei Trofimovich <slyfox@gentoo.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: 29162@debbugs.gnu.org
Subject: bug#29162: [PATCH] fix scm_make_foreign_object_n
Date: Wed, 22 Nov 2017 20:03:20 +0000 [thread overview]
Message-ID: <20171122200320.23ad3f55@sf> (raw)
In-Reply-To: <871skqz6sn.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
On Wed, 22 Nov 2017 16:12:24 +0100
ludo@gnu.org (Ludovic Courtès) wrote:
> Hi Sergei,
>
> Sergei Trofimovich <slyfox@gentoo.org> skribis:
>
> > diff --git a/libguile/foreign-object.c b/libguile/foreign-object.c
> > index 34b9f22ca..8fd2c384c 100644
> > --- a/libguile/foreign-object.c
> > +++ b/libguile/foreign-object.c
> > @@ -108,7 +108,7 @@ scm_make_foreign_object_n (SCM type, size_t n, void *vals[])
> >
> > SCM_VALIDATE_VTABLE (SCM_ARG1, type);
> >
> > - if (SCM_VTABLE_SIZE (type) / 2 < n)
> > + if (SCM_VTABLE_SIZE (type) < n)
> > scm_out_of_range (FUNC_NAME, scm_from_size_t (n));
>
> Your analysis seems right, but the code in the current ‘stable-2.2’
> branch (which corresponds to the 2.2.x stable series) has different code
> (correct code):
>
> SCM_VALIDATE_VTABLE (SCM_ARG1, type);
>
> layout = SCM_VTABLE_LAYOUT (type);
>
> if (scm_i_symbol_length (layout) / 2 < n)
> scm_out_of_range (FUNC_NAME, scm_from_size_t (n));
>
> What version were you looking at?
It was the master branch of
git://git.savannah.gnu.org/guile.git
Commit from November:
http://git.savannah.gnu.org/cgit/guile.git/commit/?id=f96a670332b224326b89ce135a0edfb77a70c46e
The link with line number:
http://git.savannah.gnu.org/cgit/guile.git/tree/libguile/foreign-object.c?id=f96a670332b224326b89ce135a0edfb77a70c46e#n111
In master branch it still seems to be around:
http://git.savannah.gnu.org/cgit/guile.git/tree/libguile/foreign-object.c#n111
--
Sergei
[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-11-22 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 22:15 bug#29162: [PATCH] fix scm_make_foreign_object_n Sergei Trofimovich
2017-11-22 15:12 ` Ludovic Courtès
2017-11-22 20:03 ` Sergei Trofimovich [this message]
2017-11-22 21:29 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122200320.23ad3f55@sf \
--to=slyfox@gentoo.org \
--cc=29162@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).