From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Sergei Trofimovich Newsgroups: gmane.lisp.guile.bugs Subject: bug#29162: [PATCH] fix scm_make_foreign_object_n Date: Sun, 5 Nov 2017 22:15:10 +0000 Message-ID: <20171105221510.12760-1-slyfox@gentoo.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1509920179 5328 195.159.176.226 (5 Nov 2017 22:16:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2017 22:16:19 +0000 (UTC) Cc: Sergei Trofimovich To: 29162@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sun Nov 05 23:16:11 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBTD9-00016T-5d for guile-bugs@m.gmane.org; Sun, 05 Nov 2017 23:16:11 +0100 Original-Received: from localhost ([::1]:45816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBTDG-0002DU-9r for guile-bugs@m.gmane.org; Sun, 05 Nov 2017 17:16:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBTD3-0002Cu-SM for bug-guile@gnu.org; Sun, 05 Nov 2017 17:16:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBTD0-0002u8-Mb for bug-guile@gnu.org; Sun, 05 Nov 2017 17:16:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBTD0-0002to-Jk for bug-guile@gnu.org; Sun, 05 Nov 2017 17:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBTD0-00069j-Bw for bug-guile@gnu.org; Sun, 05 Nov 2017 17:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sergei Trofimovich Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 05 Nov 2017 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29162 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150992013123617 (code B ref -1); Sun, 05 Nov 2017 22:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Nov 2017 22:15:31 +0000 Original-Received: from localhost ([127.0.0.1]:52759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBTCV-00068r-Jt for submit@debbugs.gnu.org; Sun, 05 Nov 2017 17:15:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBTCU-00068d-0d for submit@debbugs.gnu.org; Sun, 05 Nov 2017 17:15:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBTCN-0002Lm-TK for submit@debbugs.gnu.org; Sun, 05 Nov 2017 17:15:24 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBTCN-0002Lg-Jg for submit@debbugs.gnu.org; Sun, 05 Nov 2017 17:15:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBTCM-00026i-BX for bug-guile@gnu.org; Sun, 05 Nov 2017 17:15:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBTCJ-0002K7-3D for bug-guile@gnu.org; Sun, 05 Nov 2017 17:15:22 -0500 Original-Received: from mail.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:37539 helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBTCI-0002Iv-Sn for bug-guile@gnu.org; Sun, 05 Nov 2017 17:15:19 -0500 Original-Received: from sf.home (host86-186-94-90.range86-186.btcentralplus.com [86.186.94.90]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 70D103416F0; Sun, 5 Nov 2017 22:15:16 +0000 (UTC) Original-Received: by sf.home (Postfix, from userid 1000) id E4EA81C75F975; Sun, 5 Nov 2017 22:15:11 +0000 (GMT) X-Mailer: git-send-email 2.15.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8879 Archived-At: Noticed the error when ran test suite on ia64 but failure is not specific to t. x86_64 is as broken. test-foreign-object-c fails as: ``` Backtrace: 0 (apply-smob/1 #) ERROR: In procedure apply-smob/1: ERROR: In procedure make-foreign-object: Value out of range: 2 FAIL: test-foreign-object-c ``` The cause of the failure is wrong check for amount of available slots prepared by 'scm_make_foreign_object_type'. The fix is easy: check for amount of slots available. * libguile/foreign-object.c(scm_make_foreign_object_n): fix slot count check in foreign object constructors. Signed-off-by: Sergei Trofimovich --- libguile/foreign-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libguile/foreign-object.c b/libguile/foreign-object.c index 34b9f22ca..8fd2c384c 100644 --- a/libguile/foreign-object.c +++ b/libguile/foreign-object.c @@ -108,7 +108,7 @@ scm_make_foreign_object_n (SCM type, size_t n, void *vals[]) SCM_VALIDATE_VTABLE (SCM_ARG1, type); - if (SCM_VTABLE_SIZE (type) / 2 < n) + if (SCM_VTABLE_SIZE (type) < n) scm_out_of_range (FUNC_NAME, scm_from_size_t (n)); for (i = 0; i < n; i++) -- 2.15.0