From: "Ludovic Courtès" <ludo@gnu.org>
To: wingo@igalia.com
Cc: "Ludovic Courtès" <ludo@gnu.org>, 28590@debbugs.gnu.org
Subject: bug#28590: [PATCH 4/7] weak-table: Always unregister previous links when inserting an entry.
Date: Tue, 3 Oct 2017 13:43:49 +0200 [thread overview]
Message-ID: <20171003114352.13984-5-ludo@gnu.org> (raw)
In-Reply-To: <20171003114352.13984-1-ludo@gnu.org>
* libguile/weak-table.c (weak_table_put_x): Always call
'unregister_disappearing_links' before returning.
---
libguile/weak-table.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libguile/weak-table.c b/libguile/weak-table.c
index 7d8633165..b5db3ef48 100644
--- a/libguile/weak-table.c
+++ b/libguile/weak-table.c
@@ -731,9 +731,9 @@ weak_table_put_x (scm_t_weak_table *table, unsigned long hash,
return;
}
- if (entries[k].hash)
- unregister_disappearing_links (&entries[k], table->kind);
- else
+ unregister_disappearing_links (&entries[k], table->kind);
+
+ if (!entries[k].hash)
table->n_items++;
entries[k].hash = hash;
--
2.14.2
next prev parent reply other threads:[~2017-10-03 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 8:49 bug#28590: Weak tables in 2.2.2 grow indefinitely Ludovic Courtès
2017-09-26 9:57 ` Ludovic Courtès
2017-10-02 9:53 ` Ludovic Courtès
2017-10-03 11:43 ` bug#28590: [PATCH 0/7] Attempt to reduce memory growth Ludovic Courtès
2017-10-03 11:43 ` bug#28590: [PATCH 1/7] weak-table: Fix unbounded growth of the disappearing link table Ludovic Courtès
2017-10-03 11:43 ` bug#28590: [PATCH 2/7] weak-table: Stress the GC a little less when resizing Ludovic Courtès
2017-10-03 11:43 ` bug#28590: [PATCH 3/7] weak-table: Make sure 'move_disappearing_links' actually moves links Ludovic Courtès
2017-10-03 11:43 ` Ludovic Courtès [this message]
2017-10-03 11:43 ` bug#28590: [PATCH 5/7] weak-table: 'move_weak_entry' reports disappeared links Ludovic Courtès
2017-10-03 11:43 ` bug#28590: [PATCH 6/7] weak-table: 'rob_from_rich' accounts for disappeared entries Ludovic Courtès
2017-10-03 11:43 ` bug#28590: [PATCH 7/7] weak-table: Resize less frequently Ludovic Courtès
2017-10-04 13:09 ` bug#28590: [PATCH 0/7] Attempt to reduce memory growth Ludovic Courtès
2017-10-05 14:09 ` Ludovic Courtès
2017-11-07 10:58 ` bug#28590: Weak tables in 2.2.2 grow indefinitely Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003114352.13984-5-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=28590@debbugs.gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).