From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Klausner Newsgroups: gmane.lisp.guile.bugs Subject: bug#25923: pkgsrc patches: improve mkostemp support Date: Wed, 1 Mar 2017 21:29:26 +0100 Message-ID: <20170301202926.mh7uireewfygr4zc@danbala> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="k4l7etcti2ubxtkz" X-Trace: blaine.gmane.org 1488400213 20190 195.159.176.226 (1 Mar 2017 20:30:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Mar 2017 20:30:13 +0000 (UTC) Cc: Greg Troxel To: 25923@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Mar 01 21:30:07 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsw-0004bE-4C for guile-bugs@m.gmane.org; Wed, 01 Mar 2017 21:30:06 +0100 Original-Received: from localhost ([::1]:48657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjAt2-0007Do-9X for guile-bugs@m.gmane.org; Wed, 01 Mar 2017 15:30:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjAsw-0007BA-8T for bug-guile@gnu.org; Wed, 01 Mar 2017 15:30:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAst-0000GH-JG for bug-guile@gnu.org; Wed, 01 Mar 2017 15:30:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36690) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjAst-0000Fc-Gg for bug-guile@gnu.org; Wed, 01 Mar 2017 15:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cjAst-0001Dq-6i for bug-guile@gnu.org; Wed, 01 Mar 2017 15:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Klausner Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 01 Mar 2017 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25923 X-GNU-PR-Package: guile X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14884001794625 (code B ref -1); Wed, 01 Mar 2017 20:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Mar 2017 20:29:39 +0000 Original-Received: from localhost ([127.0.0.1]:34886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsV-0001CV-8R for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsT-0001CI-Ov for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAsN-0007x3-Qc for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:32 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjAsN-0007wj-Nl for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjAsM-00077w-BJ for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAsJ-0007rm-MH for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:30 -0500 Original-Received: from danbala.ifoer.tuwien.ac.at ([128.130.168.114]:50476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjAsJ-0007qU-FM for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:27 -0500 Original-Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) id 50CFCA583; Wed, 1 Mar 2017 21:29:26 +0100 (CET) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8643 Archived-At: --k4l7etcti2ubxtkz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline And the final pkgsrc patch tries to use only the flags for mkostemp that are supported on the operating system, in particular for Darwin and NetBSD. Please merge this one as well. Thanks, Thomas --k4l7etcti2ubxtkz Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-libguile_filesys.c" $NetBSD: patch-libguile_filesys.c,v 1.3 2017/02/21 15:55:28 gdt Exp $ When using mkostemp (an interface not defined by POSIX), restrict flags to the set defined by the documentation of particular operating systems. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 for discussion. This patch has not yet been sent upstream. --- libguile/filesys.c.orig 2016-12-15 00:03:33.000000000 +0000 +++ libguile/filesys.c @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1 mode_bits = scm_i_mode_bits (mode); } +#ifdef __APPLE__ + /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */ + open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC; +#endif +#ifdef __NetBSD__ + /* Restrict to list of flags documented in man page. */ + open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC; +#endif + SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags)); if (rv == -1) SCM_SYSERROR; --k4l7etcti2ubxtkz--