goops: make 'allowing' the use of non existing init kw or slot

goops: make 'allowing' the use of non existing init kw or slot

[David Pirotte]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

Hello,

The attached code speaks for itself: shouldn't we get an error on both of these
attempts?

	1]	the slot exists but no :init-keyword was defined;
	2]	the slot does not exists.

Cheers,
David

[-- Attachment #2: goops-make-using-non-existing-kw-or-slot.scm --]
[-- Type: text/x-scheme, Size: 585 bytes --]


(define-module (goops-make-using-non-existing-kw-or-slot)
  :use-module (oop goops)

  :export (<widget-a>
	    dialog
	    no-kw

	    letstry
	    ))


(define-class <widget-a> ()
  (dialog :accessor dialog :init-keyword :dialog :init-value #f)
  (no-kw :accessor no-kw :init-value #f))

(define (letstry)
  (make <widget-a>
    :dialog 'dialog-a
    :no-kw 'no-kw
    :non-existing-slot 'non-existing-slot))


#!

(use-modules (macros push))
(push! "/usr/local/share/guile/alto/2.0/tests"
       %load-path)

(use-modules (goops-make-using-non-existing-kw-or-slot))
(letstry)


!#

Re: goops: make 'allowing' the use of non existing init kw or slot

[Andy Wingo]

Hi,

On Sat 20 Aug 2011 21:28, David Pirotte <david@altosw.be> writes:

> The attached code speaks for itself

It does, but it takes me time to parse it.  If possible I prefer a
format of giving short examples inline with a mail message, saying what
you expect should happen, then saying what actually happens.  Just
saying :)


> shouldn't we get an error on both of these attempts?
>
> 	1]	the slot exists but no :init-keyword was defined;
> 	2]	the slot does not exists.

That is not how things have worked in the past.  The algorithm goes,
"for each slot definition, initialize it."  It doesn't go, "for each
keyword-argument pair, see what slot corresponds to it, and error
otherwise".

I think we would need some deeper CLOS / GOOPS insight here to change
this.

Andy
-- 
http://wingolog.org/