* [bug #30072] rest pattern after ellipsis
@ 2010-06-07 18:43 Szavai Gyula
2011-06-09 21:39 ` Stefan Israelsson Tampe
0 siblings, 1 reply; 6+ messages in thread
From: Szavai Gyula @ 2010-06-07 18:43 UTC (permalink / raw)
To: Szavai Gyula, bug-guile
URL:
<http://savannah.gnu.org/bugs/?30072>
Summary: rest pattern after ellipsis
Project: Guile
Submitted by: szgyg
Submitted on: Mon 07 Jun 2010 06:43:36 PM GMT
Category: None
Severity: 3 - Normal
Item Group: None
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
#|
R6RS-lib 12.4:
"P is of the form (P1 ... Pk Pe <ellipsis> Pm+1 ... Pn . Px), where
<ellipsis> is the identifier ... and F is a list or improper list of n
elements whose first k elements match P1 through Pk, whose next m - k elements
each match Pe, whose next n - m elements match Pm+1 through Pn, and whose nth
and final cdr matches Px."
So, this
|#
(let-syntax ((m (syntax-rules ()
((_ ?x ... . ?y) (list ?x ... ?y)))))
(write (m '(1 2 3 . 0))))
#|
is legal, but guile produces
ERROR: In procedure macroexpand:
ERROR: syntax-case: misplaced ellipsis in (dummy ?x ... . ?y)
|#
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30072>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug #30072] rest pattern after ellipsis
2010-06-07 18:43 [bug #30072] rest pattern after ellipsis Szavai Gyula
@ 2011-06-09 21:39 ` Stefan Israelsson Tampe
2011-06-17 18:17 ` Andy Wingo
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Israelsson Tampe @ 2011-06-09 21:39 UTC (permalink / raw)
To: Szavai Gyula, Stefan Israelsson Tampe, bug-guile
Follow-up Comment #1, bug #30072 (project guile):
Tried to fix ice-9/psyntax.scm to allow for this descreptancy
(define-syntax m
(syntax-rules ()
((_ ?x ... . ?y) (list ?x ... ?y))))
(write (m 1 2 3 . 0))
does work with supplied patch
(file #23514)
_______________________________________________________
Additional Item Attachment:
File name: elipsis.diff Size:2 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30072>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug #30072] rest pattern after ellipsis
2011-06-09 21:39 ` Stefan Israelsson Tampe
@ 2011-06-17 18:17 ` Andy Wingo
2011-06-17 21:36 ` Stefan Israelsson Tampe
0 siblings, 1 reply; 6+ messages in thread
From: Andy Wingo @ 2011-06-17 18:17 UTC (permalink / raw)
To: Andy Wingo, Szavai Gyula, Stefan Israelsson Tampe, bug-guile
Follow-up Comment #2, bug #30072 (project guile):
Thanks for the patch Stefan, it makes sense to me. Would you like to clean it
up as a git-format-patch, with a commit log?
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30072>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug #30072] rest pattern after ellipsis
2011-06-17 18:17 ` Andy Wingo
@ 2011-06-17 21:36 ` Stefan Israelsson Tampe
2011-06-20 12:27 ` Stefan Israelsson Tampe
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Israelsson Tampe @ 2011-06-17 21:36 UTC (permalink / raw)
To: Andy Wingo, Szavai Gyula, Stefan Israelsson Tampe, bug-guile
Follow-up Comment #3, bug #30072 (project guile):
Ok the git format patch is in ellipsis.mb.diff
(file #23536)
_______________________________________________________
Additional Item Attachment:
File name: ellipsis.mb.diff Size:3 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30072>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug #30072] rest pattern after ellipsis
2011-06-17 21:36 ` Stefan Israelsson Tampe
@ 2011-06-20 12:27 ` Stefan Israelsson Tampe
2011-06-21 20:46 ` Andy Wingo
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Israelsson Tampe @ 2011-06-20 12:27 UTC (permalink / raw)
To: Andy Wingo, Szavai Gyula, Stefan Israelsson Tampe, bug-guile
Follow-up Comment #4, bug #30072 (project guile):
Added a better changelog and email to the patch
see ellipsis2.mb.diff
(file #23538)
_______________________________________________________
Additional Item Attachment:
File name: ellipsis2.mb.diff Size:3 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30072>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug #30072] rest pattern after ellipsis
2011-06-20 12:27 ` Stefan Israelsson Tampe
@ 2011-06-21 20:46 ` Andy Wingo
0 siblings, 0 replies; 6+ messages in thread
From: Andy Wingo @ 2011-06-21 20:46 UTC (permalink / raw)
To: Andy Wingo, Szavai Gyula, Stefan Israelsson Tampe, bug-guile
Update of bug #30072 (project guile):
Status: None => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #5:
Pushed the fix. I made some small alterations to the commit log; do take a
look for the future. Thanks again!
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30072>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-21 20:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-07 18:43 [bug #30072] rest pattern after ellipsis Szavai Gyula
2011-06-09 21:39 ` Stefan Israelsson Tampe
2011-06-17 18:17 ` Andy Wingo
2011-06-17 21:36 ` Stefan Israelsson Tampe
2011-06-20 12:27 ` Stefan Israelsson Tampe
2011-06-21 20:46 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).