From: <dsmich@roadrunner.com>
To: "Ludovic Courtès" <ludo@gnu.org>, bug-guile@gnu.org
Subject: Re: Failures in ‘threads.test’
Date: Tue, 29 Mar 2011 21:27:02 -0400 [thread overview]
Message-ID: <20110330012702.1D122.98586.root@cdptpa-web05-z02> (raw)
In-Reply-To: <87zkoda9af.fsf@gnu.org>
---- "Ludovic Courtès" <ludo@gnu.org> wrote:
> Hi Dale,
Greetings. Thanks for taking a look. And for adding a Subject: (oops!)
> An easy answer, but there’s some truth in it:
>
> <dsmich@roadrunner.com> writes:
>
> > With guile at v2.0.0-134-g38c50a9, I'm getting a couple of failures in threads.test on my single core Debian Squeeze machine:
> >
> > FAIL: threads.test: lock-mutex: timed locking succeeds if mutex unlocked within timeout
>
> This one may be sensitive to load. Can you try changing
> (+ (current-time) 2) to (+ (current-time) 5)?
Still failing. Ok I take that back. There was two places with (+ (current-time) 2). After changing the other one it is *not* failing.
diff --git a/test-suite/tests/threads.test b/test-suite/tests/threads.test
index 2ffffb5..ba0a2a1 100644
--- a/test-suite/tests/threads.test
+++ b/test-suite/tests/threads.test
@@ -213,7 +213,7 @@
(signal-condition-variable c)
(unlock-mutex cm)
(lock-mutex m
- (+ (current-time) 2))))))
+ (+ (current-time) 5))))))
(lock-mutex m)
(wait-condition-variable c cm)
(unlock-mutex cm)
> > FAIL: threads.test: mutex-ownership: mutex with owner not retained (bug #27450)
>
> This one is GC-sensitive. It’s already kludged at length to improve the
> chances of success, but I don’t know how to improve the situation. It
> could throw unresolved instead of failing, but that doesn’t really
> help...
This message I think I never see when running the test directly. Only with "make check" do I see it. Yeah, three times in a row with make check, never with ./check-guile threads.test.
I'm running 7.2alpha5 libgc. From that tarball I think, not cvs.
-Dale
prev parent reply other threads:[~2011-03-30 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 13:03 (no subject) dsmich
2011-03-29 21:47 ` Failures in ‘threads.test’ Ludovic Courtès
2011-03-30 1:27 ` dsmich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330012702.1D122.98586.root@cdptpa-web05-z02 \
--to=dsmich@roadrunner.com \
--cc=bug-guile@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).