[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Patrick McCarty]

URL:
  <http://savannah.gnu.org/bugs/?30623>

                 Summary: `module-public-interface' returns #f for
`the-scm-module'
                 Project: Guile
            Submitted by: pnorcks
            Submitted on: Sun 01 Aug 2010 02:00:24 PM PDT
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hello,

LilyPond relies on `the-scm-module' having a public interface, but it seems
that this interface is not detected with Guile 1.9 (git):

  scheme@(guile-user)> (module-public-interface the-scm-module)
  $1 = #f
  scheme@(guile-user)>

The above call works just fine in Guile 1.8:

  guile> (module-public-interface the-scm-module)
  #<interface (guile) 7f70cf007840>
  guile>


Thanks,
Patrick




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Patrick McCarty]

Follow-up Comment #1, bug #30623 (project guile):

I just noticed that using `the-root-module' seems to work with both Guile 1.8
and 1.9:

  scheme@(guile-user)> (module-public-interface the-root-module)
  $1 = #<interface (guile) 1573d80>
  scheme@(guile-user)>

Should LilyPond use `the-root-module' instead?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Ludovic Courtès]

Follow-up Comment #2, bug #30623 (project guile):

Actually:

#v+
scheme@(guile-user)> (eq? (module-public-interface the-root-module)
the-scm-module)
$1 = #t
#v-

So I didn’t expect ‘the-scm-module’ to have a public interface.

With 1.8:

#v+
guile> (eq? (module-public-interface the-root-module) the-scm-module)
$1 = #t
guile> (eq? (module-public-interface the-scm-module) the-scm-module)
$2 = #t
#v-

We could change 1.9 to have ‘the-scm-module’ be its interface, as in 1.8,
if that helps you.

What do you think?

Thanks,
Ludo’.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Patrick McCarty]

Follow-up Comment #3, bug #30623 (project guile):

Hi,

Soon, we will be changing our use of


  (module-public-interface the-scm-module)


to


  (module-public-interface the-root-module)


instead.

In other words, we won't need a backwards-compatible fix after all.

Thanks,
Patrick

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Ludovic Courtès]

Follow-up Comment #4, bug #30623 (project guile):

OK.

As I said,

  (eq? (module-public-interface the-root-module) the-scm-module)

Why don't you just use `the-scm-module' then?

Ludo'.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Patrick McCarty]

Follow-up Comment #5, bug #30623 (project guile):

Sorry, I tried to isolate the problem for you without telling the whole
story...

In the LilyPond source (lily/ly-module.cc), we have


SCM
ly_use_module (SCM mod, SCM used)
{
  SCM expr
    = scm_list_3 (ly_symbol2scm ("module-use!"),
		  mod,
		  scm_list_2 (ly_symbol2scm ("module-public-interface"),
			      used));

  return scm_eval (expr, global_lily_module);
}


There is a call to this function with the equivalent of `the-scm-module' as
the second argument.

In this situation, it would definitely be easier for us just to replace
`the-scm-module' with `the-root-module'.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[bug #30623] `module-public-interface' returns #f for `the-scm-module'

[Ludovic Courtès]

Update of bug #30623 (project guile):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #6:

Commit 7354a105cdd86d57a7c4805d736497acdf735d56 changes `the-scm-module' to be
its own public interface, thanks!

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30623>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/