[bug #30167] func-name (#define FUNC_NAME) check not applied fully

[bug #30167] func-name (#define FUNC_NAME) check not applied fully

[Thien-Thi Nguyen]

URL:
  <http://savannah.gnu.org/bugs/?30167>

                 Summary: func-name (#define FUNC_NAME) check not applied
fully
                 Project: Guile
            Submitted by: ttn
            Submitted on: gio 17 giu 2010 14:42:17 CEST
                Category: None
                Severity: 2 - Minor
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: ttn
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

In libguile/Makefile.am, the awk script guile-func-name-check is not being
applied to pairs.c and memoize.c because those files are not derivable from
the *DOT_DOC_FILES variables.  This incomplete coverage ensures ignorance of
(possible, future) func-name bugs there, which is undesirable.

Running the check manually on those files produces spurious warnings (false
positives), which is probably one reason why they were omitted in the first
place.

There are some related infelicities surrounding this situation:

1/ The awk script is run in the .c.doc pattern rule.  Is that really
necessary?  It's a static check -- why not move it some dedicated target, like
"make function-name-check", that can be called less frequently (by
maintainers)?  See 3/ below.

2/ The long lists of mostly-redundant filenames is bug-prone.  Better to
restructure the groupings additively and make use of Automake support for
$(VAR:OLD=NEW) syntax.

3/ It's awk.  That is an affront to my scheming sensibilities.
The doc extraction/processing flow tail already uses Scheme, why not the
nose, as well?!





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30167>

_______________________________________________
  Messaggio inviato con/da Savannah
  http://savannah.gnu.org/

[bug #30167] libguile/Makefile.am ugly

[Thien-Thi Nguyen]

Update of bug #30167 (project guile):

                 Summary: func-name (#define FUNC_NAME) check not applied
fully => libguile/Makefile.am ugly

    _______________________________________________________

Follow-up Comment #1:

Actually, both those files are indeed checked, so this is really a non-bug! 
(Nice mini-rant there, however...)

Changing the title.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30167>

_______________________________________________
  Messaggio inviato con/da Savannah
  http://savannah.gnu.org/

[bug #30167] libguile/Makefile.am ugly

[Ludovic Courtès]

Update of bug #30167 (project guile):

                  Status:                    None => Invalid                
             Open/Closed:                    Open => Closed                 


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30167>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/