From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.lisp.guile.bugs Subject: [bug #30167] func-name (#define FUNC_NAME) check not applied fully Date: Thu, 17 Jun 2010 12:42:19 +0000 Message-ID: <20100617-144218.sv208.65645@savannah.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Trace: dough.gmane.org 1276778562 29681 80.91.229.12 (17 Jun 2010 12:42:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Jun 2010 12:42:42 +0000 (UTC) To: Thien-Thi Nguyen , bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Jun 17 14:42:40 2010 connect(): No such file or directory Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OPEQZ-0006yD-Bw for guile-bugs@m.gmane.org; Thu, 17 Jun 2010 14:42:39 +0200 Original-Received: from localhost ([127.0.0.1]:34125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPEQX-0003iP-PZ for guile-bugs@m.gmane.org; Thu, 17 Jun 2010 08:42:37 -0400 Original-Received: from [140.186.70.92] (port=50787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPEQQ-0003iK-Pv for bug-guile@gnu.org; Thu, 17 Jun 2010 08:42:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPEQP-0002rN-NV for bug-guile@gnu.org; Thu, 17 Jun 2010 08:42:30 -0400 Original-Received: from colonialone.fsf.org ([140.186.70.51]:58981 helo=internal.in.savannah.gnu.org) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPEQP-0002rF-LK for bug-guile@gnu.org; Thu, 17 Jun 2010 08:42:29 -0400 Original-Received: from [10.1.0.103] (helo=frontend.in.savannah.gnu.org) by internal.in.savannah.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPEQJ-0001f7-Ox; Thu, 17 Jun 2010 12:42:25 +0000 Original-Received: from www-data by frontend.in.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1OPEQF-0002ia-Ij; Thu, 17 Jun 2010 12:42:20 +0000 X-Savane-Server: savannah.gnu.org:443 [10.1.0.103] X-Savane-Project: guile X-Savane-Tracker: bugs X-Savane-Item-ID: 30167 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.19) Gecko/2010033100 Iceweasel/3.0.6 (Debian-3.0.6-3) X-Apparently-From: 95.244.66.34 (Savane authenticated user ttn) Original-References: In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4668 Archived-At: URL: Summary: func-name (#define FUNC_NAME) check not applied fully Project: Guile Submitted by: ttn Submitted on: gio 17 giu 2010 14:42:17 CEST Category: None Severity: 2 - Minor Item Group: None Status: None Privacy: Public Assigned to: ttn Open/Closed: Open Discussion Lock: Any _______________________________________________________ Details: In libguile/Makefile.am, the awk script guile-func-name-check is not being applied to pairs.c and memoize.c because those files are not derivable from the *DOT_DOC_FILES variables. This incomplete coverage ensures ignorance of (possible, future) func-name bugs there, which is undesirable. Running the check manually on those files produces spurious warnings (false positives), which is probably one reason why they were omitted in the first place. There are some related infelicities surrounding this situation: 1/ The awk script is run in the .c.doc pattern rule. Is that really necessary? It's a static check -- why not move it some dedicated target, like "make function-name-check", that can be called less frequently (by maintainers)? See 3/ below. 2/ The long lists of mostly-redundant filenames is bug-prone. Better to restructure the groupings additively and make use of Automake support for $(VAR:OLD=NEW) syntax. 3/ It's awk. That is an affront to my scheming sensibilities. The doc extraction/processing flow tail already uses Scheme, why not the nose, as well?! _______________________________________________________ Reply to this item at: _______________________________________________ Messaggio inviato con/da Savannah http://savannah.gnu.org/