From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Israelsson Tampe Newsgroups: gmane.lisp.guile.bugs Subject: [bug #25525] Segfault using goops Date: Fri, 16 Apr 2010 11:26:08 +0000 Message-ID: <20100416-112607.sv78157.61353@savannah.gnu.org> References: <20090209-102551.sv30818.41553@savannah.gnu.org> <20090209-231713.sv185.81677@savannah.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Trace: dough.gmane.org 1271417233 26490 80.91.229.12 (16 Apr 2010 11:27:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 16 Apr 2010 11:27:13 +0000 (UTC) To: Neil Jerram , Michael Burschik , Stefan Israelsson Tampe , bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Apr 16 13:27:10 2010 connect(): No such file or directory Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O2jhQ-00087u-Uz for guile-bugs@m.gmane.org; Fri, 16 Apr 2010 13:27:05 +0200 Original-Received: from localhost ([127.0.0.1]:40643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2jhP-0005lT-Sd for guile-bugs@m.gmane.org; Fri, 16 Apr 2010 07:27:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2jhK-0005l2-Aa for bug-guile@gnu.org; Fri, 16 Apr 2010 07:26:58 -0400 Original-Received: from [140.186.70.92] (port=57846 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2jhI-0005jd-Sl for bug-guile@gnu.org; Fri, 16 Apr 2010 07:26:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2jh7-0001ns-U5 for bug-guile@gnu.org; Fri, 16 Apr 2010 07:26:48 -0400 Original-Received: from colonialone.fsf.org ([140.186.70.51]:53506 helo=internal.in.savannah.gnu.org) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2jh7-0001nk-R2 for bug-guile@gnu.org; Fri, 16 Apr 2010 07:26:45 -0400 Original-Received: from [10.1.0.103] (helo=frontend.in.savannah.gnu.org) by internal.in.savannah.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2jgW-00066A-1N; Fri, 16 Apr 2010 11:26:08 +0000 Original-Received: from www-data by frontend.in.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1O2jgW-0007gs-08; Fri, 16 Apr 2010 11:26:08 +0000 X-Savane-Server: savannah.gnu.org:443 [10.1.0.103] X-Savane-Project: guile X-Savane-Tracker: bugs X-Savane-Item-ID: 25525 User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 X-Apparently-From: 82.182.254.46 (Savane authenticated user tampe) In-Reply-To: <20090209-231713.sv185.81677@savannah.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4572 Archived-At: Follow-up Comment #2, bug #25525 (project guile): The reason is that code assume cpl to be a null terminated list but it's not due to the bug, then a cdr will make the crash. Now this is a symptom and not the cause. But we can avoid a segmentation fault by making sure that we check for a pair although it will slow down the algorithm a little. Checking for a pairs and silently move on if error yield an error in a layout check! Better to fix the cause, right? Well to raise a question. by coding for efficiency and assume that the code will be used correctly we will gain speed. On the other hand this means that any bug will, with maybe to high probability, crash the repl. I would prefere to use fast and unsecure paths only for proven datastructures. Or, next best, use checks that is on only under a debug compile! _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/