unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Volker Grabsch <vog@notjusthosting.com>
To: guile-devel@gnu.org
Cc: bug-guile@gnu.org
Subject: Portability fixes for win32 cross compiling
Date: Thu, 15 Apr 2010 02:51:16 +0200	[thread overview]
Message-ID: <20100415005116.GB28615@flap> (raw)

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

Dear Guile developers,

I recently added support for your great guile library to
the mingw-cross-env project. In order to make this work,
I had to perform some portability fixes.

I originally created the fixes for the latest stable version
(guile 1.8.7), but I ported them forward to your current
development version. See the attached patches.
(generated with "git format-patch origin/master..HEAD")

Note that this doesn't solve all issues. I wasn't able to
forward-port my corrections to libguile/__scm.h regarding
win32 cross compiling of a _static_ libguile. Well, I could
provide something, but I'm unable to test it, because I'm
stuck with another problem introduced in 1.9.x:

The "gen-scmconfig" script includes a mix of native and
cross headers, which goes horribly wrong when performing
win32 cross compiling. Is it really necessary to #include
the "uniconv.h" from the cross system and to provide corresponding
SCM_ICONVEH_* constants?

Another note, regarding my patch for the "pthread_att_get_stack"
check: I assumed that when in doubt (i.e. when cross-compiling),
it is safe to set "works=no". However, I'm not sure about
that. Maybe this feature is so common that one should assume
"works=yes" when cross-compiling.


Greets,

    Volker

-- 
Volker Grabsch
---<<(())>>---
Administrator
NotJustHosting GbR

[-- Attachment #2: 0001-add-pdcurses-to-the-list-of-termlibs.patch --]
[-- Type: text/x-diff, Size: 792 bytes --]

From 6a05429f8da76475b7fc03ad42d308b98f6b777b Mon Sep 17 00:00:00 2001
From: Volker Grabsch <vog@notjusthosting.com>
Date: Thu, 15 Apr 2010 00:58:22 +0200
Subject: [PATCH] add pdcurses to the list of termlibs

---
 acinclude.m4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/acinclude.m4 b/acinclude.m4
index 2f1466b..8cfe1d4 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -378,7 +378,7 @@ dnl
 dnl Check all the things needed by `guile-readline', the Readline
 dnl bindings.
 AC_DEFUN([GUILE_READLINE], [
-  for termlib in ncurses curses termcap terminfo termlib ; do
+  for termlib in ncurses curses termcap terminfo termlib pdcurses ; do
      AC_CHECK_LIB(${termlib}, [tgoto],
        [READLINE_LIBS="-l${termlib} $READLINE_LIBS"; break])
   done
-- 
1.5.6.5


[-- Attachment #3: 0002-don-t-run-the-pthread_att_get_stack-check-when-cross.patch --]
[-- Type: text/x-diff, Size: 992 bytes --]

From fc80796464b051294280bba5af8ee4c25bef7c70 Mon Sep 17 00:00:00 2001
From: Volker Grabsch <vog@notjusthosting.com>
Date: Thu, 15 Apr 2010 01:01:23 +0200
Subject: [PATCH] don't run the pthread_att_get_stack check when cross compiling

---
 configure.ac |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/configure.ac b/configure.ac
index 73a4bd2..c6f480a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1413,6 +1413,7 @@ if test "$with_threads" = pthreads; then
 AC_MSG_CHECKING(whether pthread_attr_getstack works for the main thread)
 old_CFLAGS="$CFLAGS"
 CFLAGS="$PTHREAD_CFLAGS $CFLAGS"
+if test "$cross_compiling" = "no"; then
 AC_RUN_IFELSE([AC_LANG_SOURCE([[
 #if HAVE_PTHREAD_ATTR_GETSTACK
 #include <pthread.h>
@@ -1443,6 +1444,9 @@ int main ()
 AC_DEFINE([PTHREAD_ATTR_GETSTACK_WORKS], [1], [Define when pthread_att_get_stack works for the main thread])],
 [works=no],
 [])
+else
+works=no
+fi
 CFLAGS="$old_CFLAGS"
 AC_MSG_RESULT($works)
 
-- 
1.5.6.5


             reply	other threads:[~2010-04-15  0:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15  0:51 Volker Grabsch [this message]
2010-04-15 14:12 ` Portability fixes for win32 cross compiling Mike Gran
2010-04-15 20:58   ` Volker Grabsch
2010-05-28 13:15 ` Ludovic Courtès
2010-05-28 14:44   ` Volker Grabsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100415005116.GB28615@flap \
    --to=vog@notjusthosting.com \
    --cc=bug-guile@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).