* [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates
@ 2009-03-14 17:37 Neil Jerram
2009-03-18 20:47 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Neil Jerram @ 2009-03-14 17:37 UTC (permalink / raw)
To: Neil Jerram, bug-guile
URL:
<http://savannah.gnu.org/bugs/?25865>
Summary: scm_take_locale_symboln doesn't intern the symbol
that it creates
Project: Guile
Submitted by: ossau
Submitted on: Sat 14 Mar 2009 17:37:10 GMT
Category: None
Severity: 3 - Normal
Item Group: None
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
This is inferred from code reading.
The doc for scm_take_locale_symboln says:
"Like @code{scm_from_locale_symbol} and @code{scm_from_locale_symboln},
respectively, but also frees @var{str} with @code{free} eventually."
scm_from_locale_symboln creates an interned symbol, so it follows that
scm_take_locale_symboln should too. But the relevant code is
scm_take_locale_symboln
-> scm_i_c_take_symbol
-> creates a symbol but doesn't intern it.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?25865>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates 2009-03-14 17:37 [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates Neil Jerram @ 2009-03-18 20:47 ` Ludovic Courtès 2009-03-18 21:44 ` Ludovic Courtès 0 siblings, 1 reply; 5+ messages in thread From: Ludovic Courtès @ 2009-03-18 20:47 UTC (permalink / raw) To: Ludovic Courtès, Neil Jerram, bug-guile Update of bug #25865 (project guile): Assigned to: None => civodul _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?25865> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates 2009-03-18 20:47 ` Ludovic Courtès @ 2009-03-18 21:44 ` Ludovic Courtès 2009-03-19 0:20 ` Neil Jerram 2009-03-19 21:25 ` Ludovic Courtès 0 siblings, 2 replies; 5+ messages in thread From: Ludovic Courtès @ 2009-03-18 21:44 UTC (permalink / raw) To: Ludovic Courtès, Neil Jerram, bug-guile Follow-up Comment #1, bug #25865 (project guile): Hello! I've come up with the following patch, which also refactorizes duplciated bits. I'll commit it if there's no objection. Thanks, Ludo'. (file #17730) _______________________________________________________ Additional Item Attachment: File name: 0001-Have-scm_take_locale_symbol-return-an-interned.patch Size:8 KB _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?25865> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates 2009-03-18 21:44 ` Ludovic Courtès @ 2009-03-19 0:20 ` Neil Jerram 2009-03-19 21:25 ` Ludovic Courtès 1 sibling, 0 replies; 5+ messages in thread From: Neil Jerram @ 2009-03-19 0:20 UTC (permalink / raw) To: Ludovic Courtès, bug-guile Ludovic Courtès <INVALID.NOREPLY@gnu.org> writes: > I've come up with the following patch, which also refactorizes duplciated > bits. I'll commit it if there's no objection. The patch looks fine to me. Thanks for fixing this! Neil ^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates 2009-03-18 21:44 ` Ludovic Courtès 2009-03-19 0:20 ` Neil Jerram @ 2009-03-19 21:25 ` Ludovic Courtès 1 sibling, 0 replies; 5+ messages in thread From: Ludovic Courtès @ 2009-03-19 21:25 UTC (permalink / raw) To: Ludovic Courtès, Neil Jerram, bug-guile Update of bug #25865 (project guile): Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #2: Fixed: http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=8760f4694dcc8597bb72644d8a1ca1fdf18029a2 and http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=05588a1acea43792f33ea632af0d316e847fa9db _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?25865> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-19 21:25 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-03-14 17:37 [bug #25865] scm_take_locale_symboln doesn't intern the symbol that it creates Neil Jerram 2009-03-18 20:47 ` Ludovic Courtès 2009-03-18 21:44 ` Ludovic Courtès 2009-03-19 0:20 ` Neil Jerram 2009-03-19 21:25 ` Ludovic Courtès
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).